samples: net: echo_client: Only send allowable number of bytes #5072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honor the device MTU when sending data. Signed-off-by: Jukka Rissanen <[email protected]>
This was referenced Nov 20, 2017
tbursztyka
approved these changes
Nov 20, 2017
pfalcon
approved these changes
Nov 20, 2017
dleach02
approved these changes
Nov 20, 2017
Member
dleach02
left a comment
dleach02
left a comment
There was a problem hiding this comment.
This looks fine although I'm guessing now the complexity of breaking up a large transmit has now been moved to the application layer if net_pkt_append() doesn't fit everything in?
Member
Author
Yes, that is the case. It is quite difficult to buffer the data inside the IP stack, which means that we need to push this logic upper in the stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor the device MTU when sending data.
Signed-off-by: Jukka Rissanen [email protected]