Revert "net: pkt: Take into account MTU when adding data to a packet" #4972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbursztyka
approved these changes
Nov 15, 2017
pfalcon
suggested changes
Nov 16, 2017
Contributor
|
The alternative posted: #5015 |
This was referenced Nov 17, 2017
Honor the device MTU when sending data. Signed-off-by: Jukka Rissanen <[email protected]>
Member
Author
|
I messed up this PR, so need to close it atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4718dac.
This causes issues with echo-client and other programs that call
net_pkt_append() function. The MTU returned is too short in practice
as we only have function in net_if for HW MTU and this functionality
needs more of IP MTU selection which is currently not available.
So reverting this atm before we can figure out better solution.
Fixes #4934
Signed-off-by: Jukka Rissanen [email protected]