settings: remove dead code#14738
Merged
galak merged 1 commit intozephyrproject-rtos:masterfrom Mar 20, 2019
Merged
Conversation
nvlsianpu
added
area: Configuration System
Trivial
Patch removes dead, replaced code which was accidentally not removed within the stream-codec PR zephyrproject-rtos#9521. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu
force-pushed
the
settings/rm_dreth_code
branch
from
3e0896f to
9412f9b
Compare
carlescufi
reviewed
Mar 20, 2019
|
|
||
| int settings_line_parse(char *buf, char **namep, char **valp); | ||
| int settings_line_make(char *dst, int dlen, const char *name, const char *val); | ||
| int settings_line_make2(char *dst, int dlen, const char *name, |
Member
There was a problem hiding this comment.
What about this one? You didn't remove it from the code?
Contributor
Author
There was a problem hiding this comment.
^^ was even not implemented.
pizi-nordic
approved these changes
Mar 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #14738 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 309 309
Lines 45582 45582
Branches 10555 10555
=======================================
Hits 23691 23691
Misses 17082 17082
Partials 4809 4809Continue to review full report at Codecov.
|
carlescufi
approved these changes
Mar 20, 2019
carlescufi
added
area: Storage
galak
approved these changes
Mar 20, 2019
andrewboie
approved these changes
Mar 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch removes dead, replaced code which was accidentally not
removed within the stream-codec PR #9521.
Signed-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no