Skip to content

Conversation

@loicpoulain
Copy link
Contributor

Work In Progress

Signed-off-by: Loic Poulain [email protected]

@zephyrbot
Copy link

zephyrbot commented Mar 19, 2019

Found the following issues, please fix and resubmit:

Gitlint issues

1: T5 Title contains the word 'wip' (case-insensitive): "[WIP] Introduce Video 4 Zephyr API"
1: UC3 Title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "[WIP] Introduce Video 4 Zephyr API"
1: UC6 Body has no content, should at least have 1 line.

Codeowners issues

New files added that are not covered in CODEOWNERS:

include/v4z.h

Please add one or more entries in the CODEOWNERS file to cover those files


Documentation issues

/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:173: warning: Found unknown command `\buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:174: warning: Found unknown command `\timeout'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:182: warning: The following parameters of v4z_dequeue(struct device *dev, struct v4z_buffer **buf, u32_t timeout) are not documented:
  parameter 'buf'
  parameter 'timeout'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:150: warning: Found unknown command `\buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:158: warning: The following parameters of v4z_enqueue(struct device *dev, struct v4z_buffer *buf) are not documented:
  parameter 'buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:135: warning: The following parameters of v4z_get_fmt(struct device *dev, struct v4z_format *fmt) are not documented:
  parameter 'fmt'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:135: warning: The following parameters of v4z_get_fmt(struct device *dev, struct v4z_format *fmt) are not documented:
  parameter 'fmt'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:150: warning: Found unknown command `\buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:158: warning: The following parameters of v4z_enqueue(struct device *dev, struct v4z_buffer *buf) are not documented:
  parameter 'buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:173: warning: Found unknown command `\buf'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:174: warning: Found unknown command `\timeout'
/var/lib/shippable/build/IN/main_repo/zephyr/include/v4z.h:182: warning: The following parameters of v4z_dequeue(struct device *dev, struct v4z_buffer **buf, u32_t timeout) are not documented:
  parameter 'buf'
  parameter 'timeout'



@loicpoulain loicpoulain requested review from galak and nashif March 19, 2019 10:35
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #14666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14666   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files         309      309           
  Lines       45582    45582           
  Branches    10555    10555           
=======================================
  Hits        23691    23691           
  Misses      17082    17082           
  Partials     4809     4809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f4206...a82c199. Read the comment docs.

@mbolivar
Copy link
Contributor

mbolivar commented Jun 7, 2019

New API with no CODEOWNERS change ... who will maintain this, @loicpoulain ?

@mbolivar mbolivar added the area: API Changes to public APIs label Jun 7, 2019
@loicpoulain
Copy link
Contributor Author

New API with no CODEOWNERS change ... who will maintain this, @loicpoulain ?

Well, yes, I still need to clean some code on my side, but I plan to push API along with a video driver for mimxrt10xx board.

@mbolivar
Copy link
Contributor

Well, yes, I still need to clean some code on my side, but I plan to push API along with a video driver for mimxrt10xx board.

OK, thanks!

We discussed at the API meeting today. In general, all new APIs need a maintainer who will review incoming patches and API changes in order to be merged. I take it you're willing to volunteer where this API is concerned?

@loicpoulain
Copy link
Contributor Author

I take it you're willing to volunteer where this API is concerned?

yes

@pizi-nordic pizi-nordic self-requested a review June 12, 2019 15:16
@loicpoulain
Copy link
Contributor Author

Moved to #17194

@loicpoulain loicpoulain closed this Jul 1, 2019
@loicpoulain
Copy link
Contributor Author

@gon1332 , could you please look at #17194

@gon1332
Copy link
Contributor

gon1332 commented Jul 2, 2019

@gon1332 , could you please look at #17194

I'll do. I've followed your actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: camera area: Video Video subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants