subsys: bluetooth: host: Notify outstanding request before destroying all ATT reqs #11349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olivier-ProGlove
requested review from
Vudentz,
jhedberg and
sjanc
as code owners
Olivier-ProGlove
force-pushed
the
att_reset-notify-before-destroy
branch
from
447a8cf to
af9c9d5
Compare
`att_reset()` destroys all ATT reqs (using `att_req_destroy`) and empty the ATT req queue. Calling `att_handle_rsp()` after the loop will use an invalid ATT req (all the ATT reqs have been `memset(0)`) - so the notified ATT req function called [here](https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/bluetooth/host/att.c#L325) is `NULL`. This change move the outstanding req notification before destroying all ATT reqs. Signed-off-by: Olivier Martin <[email protected]>
Olivier-ProGlove
force-pushed
the
att_reset-notify-before-destroy
branch
from
af9c9d5 to
4d48e7f
Compare
Vudentz
reviewed
Nov 16, 2018
Contributor
Vudentz
left a comment
Vudentz
left a comment
There was a problem hiding this comment.
This assumes the current request is also part of the list which is not how it was intended, so perhaps we have a but somewhere else?
Contributor
Author
|
I will close this PR when my new PR #11574 would have been accepted. |
Member
|
Hi @Olivier-ProGlove . This PR has been standing for several months now without any activity. The PR you linked to (#11574) as precondition to close this one, seems to be blocked. |
Member
|
This PR has no had any activity for almost a year. I will therefore close it under the assumption that the author (@Olivier-ProGlove) has lost interest. If that is not the case, please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
att_reset()destroys all ATT reqs (usingatt_req_destroy) and empty the ATT req queue.Calling
att_handle_rsp()after the loop will use an invalid ATT req (all the ATT reqs have beenmemset(0)) - so the notified ATT req function called here isNULL.This change move the outstanding req notification before destroying all ATT reqs.
Signed-off-by: Olivier Martin [email protected]