drivers: udc_dwc2: Double fifo size for bulk endpoints#105631
Open
tmon-nordic wants to merge 1 commit intozephyrproject-rtos:mainfrom
Open
drivers: udc_dwc2: Double fifo size for bulk endpoints#105631tmon-nordic wants to merge 1 commit intozephyrproject-rtos:mainfrom
tmon-nordic wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
tmon-nordic
force-pushed
the
dwc2-double-bulk
branch
from
8e84826 to
20e96b9
Compare
Double fifo size for bulk endpoints to allow packet to be transmitted while next one is being written to fifo. This offers significant throughput improvement when class supplies big enough buffers. On nRF54H20 with SCSI buffer size 8192 with double buffering enabled and DWC2 operating in Buffer DMA mode, the maximum throughput increases more than double when used with disk driver that does nothing in read callback (i.e. this is the upper bound possible). Gnome Disks benchmark configured for 100 samples, 8 MiB sample size measures Average Read Rate equal 33.6 MB/s with this change compared to 15.3 MB/s without it. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
tmon-nordic
force-pushed
the
dwc2-double-bulk
branch
from
20e96b9 to
77886c8
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double fifo size for bulk endpoints to allow packet to be transmitted while next one is being written to fifo. This offers significant throughput improvement when class supplies big enough buffers.
On nRF54H20 with SCSI buffer size 8192 with double buffering enabled and DWC2 operating in Buffer DMA mode, the maximum throughput increases more than double when used with disk driver that does nothing in read callback (i.e. this is the upper bound possible). Gnome Disks benchmark configured for 100 samples, 8 MiB sample size measures Average Read Rate equal 33.6 MB/s with this change compared to 15.3 MB/s without it.
I believe the proper solution is #99510. The throughput improvement is way too significant to not have it due to review disagreements, therefore I am submitting this as a standalone PR.