Skip to content

usb: udc: dwc2: split vendor quirks per-vendor#105030

Merged
kartben merged 1 commit intozephyrproject-rtos:mainfrom
josuah:udc_dwc2_quirks_split
Apr 16, 2026
Merged

usb: udc: dwc2: split vendor quirks per-vendor#105030
kartben merged 1 commit intozephyrproject-rtos:mainfrom
josuah:udc_dwc2_quirks_split

Conversation

@josuah
Copy link
Copy Markdown
Contributor

@josuah josuah commented Mar 6, 2026 •
edited by jfischer-no
Loading

Merge udc_dwc2.h into udc_dwc2.c.
Split udc_dwc2_vendor_quirks.h in one file per platform.
Add MAINTAINERS.yml rules.

  • per-vendor notification
  • easier out of tree and contrib
  • files look like normal driver, ending by DT_INST_FOREACH_STATUS_OKAY(...)
    - struct udc_dwc2_config is back into udc_dwc2.c

Is it worth the change? Textual move, no modification of the content.

@zephyrbot zephyrbot added platform: STM32 ST Micro STM32 area: USB Universal Serial Bus area: MAINTAINER File labels Mar 6, 2026
@josuah josuah added platform: ESP32 Espressif ESP32 platform: nRF Nordic nRFx labels Mar 6, 2026
@josuah josuah mentioned this pull request Mar 6, 2026
Closed
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from 0a657f4 to 50bf381 Compare March 6, 2026 12:55
@josuah
Copy link
Copy Markdown
Contributor Author

josuah commented Mar 6, 2026 •
edited
Loading

Force-push:

  • remove LOG_MODULE_DECLARE() repeated in each function, not needed anymore as a consequence of the change

mathieuchopstm
mathieuchopstm reviewed Mar 12, 2026
View reviewed changes
Comment thread drivers/usb/udc/udc_dwc2.c Outdated
Comment thread MAINTAINERS.yml
Copy link
Copy Markdown
Contributor

@mathieuchopstm mathieuchopstm Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message says it updates platforms ESP32, NRF and STM32 but only the former two are added.

Either update the commit message or add missing platform.

Copy link
Copy Markdown
Contributor Author

@josuah josuah Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch done as STM32 already had rules that match the extra quirks.

Copy link
Copy Markdown
Contributor

@jfischer-no jfischer-no Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST is not related to this quirk in any way.

@josuah josuah force-pushed the udc_dwc2_quirks_split branch from 50bf381 to 950bfe3 Compare March 12, 2026 16:27
mathieuchopstm
mathieuchopstm previously approved these changes Mar 12, 2026
View reviewed changes
tmon-nordic
tmon-nordic previously approved these changes Mar 16, 2026
View reviewed changes
@josuah
Copy link
Copy Markdown
Contributor Author

josuah commented Apr 2, 2026 •
edited
Loading

This needs to be rebased on top of this:

@tmon-nordic
Copy link
Copy Markdown
Contributor

tmon-nordic commented Apr 3, 2026

This needs to be rebased on top of this:

* [drivers: usb: add Nordic USBHS wrapper and USBHS BC12 drivers #106759](https://github.com/zephyrproject-rtos/zephyr/pull/106759)

While it needs to be rebased on top of main to solve conflicts, I don't think there is a need for this to wait for a PR that was opened later than this one, and is still not ready.

@josuah josuah mentioned this pull request Apr 3, 2026
Closed
@josuah josuah dismissed stale reviews from tmon-nordic and mathieuchopstm via 05eadfc April 3, 2026 16:06
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from 950bfe3 to 05eadfc Compare April 3, 2026 16:06
@josuah
Copy link
Copy Markdown
Contributor Author

josuah commented Apr 3, 2026

I did just re-split from udc_dwc2_vendor_quirks.h to make sure that all the content is up to date.

jfischer-no
jfischer-no requested changes Apr 14, 2026
View reviewed changes
Comment thread drivers/usb/udc/udc_dwc2.c
Comment thread drivers/usb/udc/udc_dwc2.c Outdated
Comment thread MAINTAINERS.yml
Copy link
Copy Markdown
Contributor

@jfischer-no jfischer-no Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST is not related to this quirk in any way.

@jfischer-no
Copy link
Copy Markdown
Contributor

jfischer-no commented Apr 14, 2026

This should go in right after #103779.

@josuah josuah added the DNM This PR should not be merged (Do Not Merge) label Apr 15, 2026
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from 05eadfc to c20db91 Compare April 15, 2026 13:43
@josuah
Copy link
Copy Markdown
Contributor Author

josuah commented Apr 15, 2026

DNM until things are fixed, rebased on top of latest main for #103779

@zephyrbot zephyrbot requested a review from jfischer-no April 15, 2026 13:45
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from c20db91 to 65c9a1e Compare April 15, 2026 14:40
@josuah josuah removed the DNM This PR should not be merged (Do Not Merge) label Apr 15, 2026
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from 65c9a1e to e69a359 Compare April 15, 2026 16:36
drivers: usb: udc: dwc2: split vendor quirks per-vendor
5ed6981 
Use one file per vendor quirk. No modification to any content,
only the same code being moved to separate files.

Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
@josuah josuah force-pushed the udc_dwc2_quirks_split branch from e69a359 to 5ed6981 Compare April 15, 2026 18:14
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.5% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 57f0805 into zephyrproject-rtos:main Apr 16, 2026
30 of 31 checks passed
@josuah josuah deleted the udc_dwc2_quirks_split branch April 19, 2026 23:12
@josuah josuah mentioned this pull request Apr 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfischer-no jfischer-no jfischer-no approved these changes

@carlescufi carlescufi carlescufi approved these changes

@tmon-nordic tmon-nordic tmon-nordic left review comments

@mathieuchopstm mathieuchopstm mathieuchopstm left review comments

@anangl anangl Awaiting requested review from anangl

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@juickar juickar Awaiting requested review from juickar

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@jfischer-no jfischer-no

Labels

area: Modem Drivers area: USB Universal Serial Bus platform: ESP32 Espressif ESP32 platform: nRF Nordic nRFx platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@josuah @tmon-nordic @jfischer-no @carlescufi @mathieuchopstm @kartben @zephyrbot