Change priorities related to TISCI and other components#104673
Change priorities related to TISCI and other components#104673aescolar merged 3 commits intozephyrproject-rtos:mainfrom
Conversation
zephyrbot
added
area: mbox
platform: TI K3
zephyrbot
requested review from
LaurentiuM1234,
gramsay0,
ithinuel,
nordic-krch,
vaishnavachath,
wearyzen and
yongxu-wang15
| @@ -10,6 +10,6 @@ config MBOX_TI_SECURE_PROXY | |||
|
|
|||
| config MBOX_TI_SECURE_PROXY_PRIORITY | |||
There was a problem hiding this comment.
Why do we have a non-standard priority config to begin with? If we had just used MBOX_INIT_PRIORITY in the driver like all other mailbox drivers, we would be at the same priority as KERNEL_INIT_PRIORITY_DEVICE(40) by default.
Let's do that instead, in this patch drop MBOX_TI_SECURE_PROXY_PRIORITY and use MBOX_INIT_PRIORITY in the driver to get the same result in a more standard way.
There was a problem hiding this comment.
Removed in favor of MBOX_INIT_PRIORITY. Also changed other priorities to KERNEL_INIT_PRIORITY_DEFAULT (40). KERNEL_INIT_PRIORITY_DEVICE by defaul tis 50. Will do a quick build later to confirm this is not an issue.
|
Reverse the order of these patches, as they are now after the first patch the priorities are inverted and build fails, breaking bisectability. Start with the top driver and work down. |
makes sense, will do, thanks |
Change priority from KERNEL_INIT_PRIORITY_OBJECTS to KERNEL_INIT_PRIORITY_DEFAULT so that the priority dependency on TISCI protocol/firmware layer gets fulfilled. Signed-off-by: Amneesh Singh <amneesh@ti.com>
Change priority from KERNEL_INIT_PRIORITY_OBJECTS to KERNEL_INIT_PRIORITY_DEFAULT so that the priority dependency on TI secure proxy mailbox fulfilled. Signed-off-by: Amneesh Singh <amneesh@ti.com>
Remove MBOX_TI_SECURE_PROXY_PRIORITY in favor of MBOX_INIT_PRIORITY which by default is set to 40, which is desirable so that the priority dependency on interrupt controllers like ARM GICv3 gets fulfilled. This change is for convenience of building at default priorities. Signed-off-by: Amneesh Singh <amneesh@ti.com>
natto1784
force-pushed
the
tisci_priorities
branch
from
37b467d to
c010e6e
Compare
|
5 participants
Change priority from
KERNEL_INIT_PRIORITY_OBJECTStoKERNEL_INIT_PRIORITY_DEFAULTfor following components