boards: shields: add support for MikroElektronika Flash 6 Click#104615
Conversation
zephyrbot
added
area: Flash
area: Samples
zephyrbot
requested review from
JarmouniA,
avisconti,
de-nordic,
erwango,
jfischer-no,
kartben,
nashif and
rghaddab
rexut
force-pushed
the
tiacsys/contrib/shields/mikroe_flash_6_click
branch
2 times, most recently
from
45929e0 to
10875b5
Compare
| full_name: Flash 6 Click | ||
| vendor: mikroe | ||
| supported_features: | ||
| - mtd |
There was a problem hiding this comment.
| - mtd | |
| - flash |
There was a problem hiding this comment.
Done.
But shouldn't the shield MikroE Flash 5 Click, which was added a few weeks ago, also be updated?
zephyr/boards/shields/mikroe_flash_5_click/shield.yml
Lines 5 to 6 in ee7e0ba
There was a problem hiding this comment.
Sorry my mistake, I confused mtd with mfd, mtd appears to be used in a number of shields so it's fine.
There was a problem hiding this comment.
No problem, but I felt mtd was wrong from the beginning. The sample matches only on tags flash or shell, not mtd. There is no sample with tag mtd. Same situation for tests, so it looks now correct.
There was a problem hiding this comment.
AFAIK it has no effect anyway because twister only considers boards' feature tags, not shield, and it's something that should be fixed.
There was a problem hiding this comment.
AFAIK it has no effect anyway because twister only considers boards' feature tags, not shield, and it's something that should be fixed.
It is used for the documentation so I am not sure why you are mentioning twister or that something needs to be fixed :)
"The sample matches only on tags flash or shell, not mtd. There is no sample with tag mtd. Same situation for tests, so it looks now correct."
Sorry I still don't understand what you mean. This file, just like board.yml files has nothing to do with Twister whatsoever?
There was a problem hiding this comment.
I am not sure why you are mentioning twister or that something needs to be fixed :)
We don't have a way to filter shields by supported features with twister, like we do with boards.
There was a problem hiding this comment.
Sorry I still don't understand what you mean. This file, just like board.yml files has nothing to do with Twister whatsoever?
board.yml does not have a supported list with tags, but what does is [board-name].yml hence the confusion.
There was a problem hiding this comment.
mtd is fine. flash is not a binding type https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/bindings/binding-types.txt
So shouldn't this be checked in CI!?
Sure, but it's not like we can check every possible documentation mistake (although, yes, this one should certainly be automated).
And this PR would have been reviewed and approved by the documentation and shields maintainer who pays attention to exactly these kind of things :)
There was a problem hiding this comment.
Please revert this change
Done.
rexut
force-pushed
the
tiacsys/contrib/shields/mikroe_flash_6_click
branch
from
10875b5 to
63b73e8
Compare
rexut
force-pushed
the
tiacsys/contrib/shields/mikroe_flash_6_click
branch
from
63b73e8 to
b57f867
Compare
| `Flash 6 Click`_ is a perfect solution for the mass storage option in various | ||
| embedded applications. | ||
|
|
||
| It features the W25Q128JV_ (128M-bit) Serial NOR Flash Memory from Winbond which | ||
| provides a storage solution for systems with limited space, pins and power. | ||
| The W25Q_ SpiFlash family incorporates the popular SPI interface and the medium | ||
| sized NOR non-volatile memory space. They are ideal for code shadowing to RAM, | ||
| executing code directly from Dual/Quad SPI (XIP) and storing voice, text and | ||
| data. The small 4KB sectors allow for greater flexibility in applications that | ||
| require data and parameter storage. |
There was a problem hiding this comment.
I really have mixed feelings about copy-pasting verbatim the marketing copy from the vendor when, just like here, it uses overly enthusiastic wording.
Not asking you to change it now as I can definitely live with it but something to probably pay attention to in the future.
| - gd32f350r_eval | ||
| harness: shell | ||
| extra_args: | ||
| - platform:frdm_mcxn947/mcxn947/cpu0:SHIELD="mikroe_flash_6_click" |
There was a problem hiding this comment.
Is the sample actually functional as there are no partitions defined by the shield?
There was a problem hiding this comment.
Yes, it is. This sample is only a Zephyr Shell with Flash API and Shell enabled. Thus it doesn't need any partition, only the raw flash device for the shell sub-commands behind flash (flash page_info 0).
There was a problem hiding this comment.
But it's possible that the change in sample.yaml might not be accepted by the FRDM-MCXN947 board maintainer, because running this example on a real board would always require this shield — the SoC flash would no longer be usable — and I also see that the chosen isn't set to the flash in the shield.
The extension of sample.yaml is probably more useless than helpful. I'll remove it.
Add shield definition for the MikroElektronika Flash 6 Click shield, an mikroBUS compatible evaluation module for the Winbond W25Q128JV (128M-bit) SPI Serial NOR Flash chip. Tested with the command mentioned on the index.rst page. Signed-off-by: Stephan Linz <linz@li-pro.net>
rexut
force-pushed
the
tiacsys/contrib/shields/mikroe_flash_6_click
branch
from
b57f867 to
60cce53
Compare
|
|
There is also Flash 8 Click PR #105078 |
6 participants
Add shield definition for the MikroElektronika Flash 6 Click shield, an mikroBUS compatible evaluation module for the Winbond W25Q128JV (128M-bit) SPI Serial NOR Flash chip.
Tested with the command mentioned on the index.rst page.
Product photo from https://cdn1-shop.mikroe.com/img/product/flash-6-click/flash-6-click-thickbox_default-1.jpg (Credit: MikroElektronika).
Resulting documentation: https://builds.zephyrproject.io/zephyr/pr/104615/docs/boards/shields/mikroe_flash_6_click/doc/index.html