Skip to content

drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] #102965

Closed
roma-jam wants to merge 2 commits intozephyrproject-rtos:mainfrom
roma-jam-lab:pr-add-dwc2-uhc-vendor-quirks-esp32
Closed

drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] #102965
roma-jam wants to merge 2 commits intozephyrproject-rtos:mainfrom
roma-jam-lab:pr-add-dwc2-uhc-vendor-quirks-esp32

Conversation

@roma-jam
Copy link
Copy Markdown
Contributor

@roma-jam roma-jam commented Jan 27, 2026 •
edited by josuah
Loading

Collective Pull-request

Contains the incoming features and all the prerequisites.

Description

Added vendor specific DWC2 quirks.

This feature enables the possibility to power up the DWC2 controller and read the configuration registers.

Changes

Updated

  • drivers/usb/uhc/uhc_dwc2_vendor_quirks.h

Related

This was referenced Jan 27, 2026
Closed
Closed
Open
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch from 006d990 to 3af871b Compare January 27, 2026 15:09
@roma-jam roma-jam marked this pull request as ready for review January 27, 2026 15:29
@zephyrbot zephyrbot added the area: USB Universal Serial Bus label Jan 27, 2026
@josuah
Copy link
Copy Markdown
Contributor

josuah commented Jan 27, 2026

How about also providing the esp32s3_devkitc_procpu.overlay and all other needed files for testing this directly?

This way other PRs on top of this do not need to do manual modifications to test this.

@josuah josuah mentioned this pull request Jan 27, 2026
Draft
@josuah josuah linked an issue Jan 27, 2026 that may be closed by this pull request
DWC2 USB Host controller (UHC) #102931
Open
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch from 3af871b to 273b2e7 Compare January 28, 2026 08:25
@roma-jam
Copy link
Copy Markdown
Contributor Author

roma-jam commented Jan 28, 2026

Hi @josuah

added that in the [part2], so it is automatically present in this PR as well.

Thanks.

@zephyrbot zephyrbot added the area: Samples Samples label Jan 28, 2026
@roma-jam roma-jam changed the title [WIP] drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] Jan 28, 2026
@roma-jam roma-jam marked this pull request as draft January 29, 2026 08:59
@roma-jam roma-jam changed the title drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] [WIP] drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] Jan 29, 2026
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch 3 times, most recently from af936d7 to 87381d4 Compare February 5, 2026 09:58
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch from 87381d4 to a96116b Compare February 11, 2026 09:06
@roma-jam roma-jam changed the title [WIP] drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] drivers: usb: uhc: Added dwc2 vendor quirks for esp32 [part3] Feb 11, 2026
@roma-jam roma-jam marked this pull request as ready for review February 11, 2026 10:01
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch 2 times, most recently from 46ce20d to 593b199 Compare February 19, 2026 12:39
@roma-jam roma-jam marked this pull request as draft February 19, 2026 19:46
@roma-jam roma-jam marked this pull request as ready for review March 2, 2026 13:20
@roma-jam roma-jam mentioned this pull request Mar 2, 2026
Open
@sylvioalves
Copy link
Copy Markdown
Contributor

sylvioalves commented Mar 2, 2026

Some of my comments in #102967 applies here as the code is the same (or partially the same).

sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/Kconfig.dwc2 Outdated
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/Kconfig.dwc2 Outdated
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2_vendor_quirks.h
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2.c Outdated
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2_vendor_quirks.h Outdated
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2_vendor_quirks.h
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2.c
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2_vendor_quirks.h
sylvioalves
sylvioalves reviewed Mar 2, 2026
View reviewed changes
Comment thread drivers/usb/uhc/uhc_dwc2.c Outdated
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch from 593b199 to 013d430 Compare March 5, 2026 16:29
roma-jam added 2 commits March 9, 2026 11:41
@roma-jam
drivers: usb: uhc: Added dwc2 initial files
008ce92 
Added:
- Driver API signatures without implementation
- DT miltiinstance definition of uhc dwc2
- Stubbed vendor quirks calls for esp32
- Added the esp32s3 overlay for usb shell example for testing purpose

Signed-off-by: Roman Leonov <jam_roma@yahoo.com>
@roma-jam
drivers: usb: uhc: Added dwc2 vendor quirks for esp32
9b87edb 
- Added esp32 specific vendor PHY configuration
- Added specific esp32 IRQ configuration

Signed-off-by: Roman Leonov <jam_roma@yahoo.com>
@roma-jam roma-jam force-pushed the pr-add-dwc2-uhc-vendor-quirks-esp32 branch from 013d430 to 9b87edb Compare March 9, 2026 22:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.6% Duplication on New Code

See analysis details on SonarQube Cloud

@roma-jam roma-jam mentioned this pull request Mar 12, 2026
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions Bot added the Stale label Apr 9, 2026
@roma-jam
Copy link
Copy Markdown
Contributor Author

roma-jam commented Apr 9, 2026 •
edited
Loading

Please, remove the Stale label.

@sylvioalves sylvioalves removed the Stale label Apr 9, 2026
@sylvioalves
Copy link
Copy Markdown
Contributor

sylvioalves commented Apr 9, 2026

@roma-jam please ping back if there is pending reviews..

@roma-jam roma-jam marked this pull request as draft April 17, 2026 15:57
@roma-jam
Copy link
Copy Markdown
Contributor Author

roma-jam commented Apr 17, 2026

Will address all the rest notes in the follow-up PR, which introduces the fixed state that might be tested on a hardware.

After applying all necessary changes will close this PR.

For the follow up, please refer to the #102967.

@roma-jam
Copy link
Copy Markdown
Contributor Author

roma-jam commented Apr 20, 2026

All notes from this PR have been noted and considered in follow-up PR.
To proceed, please follow the #102967.

@roma-jam roma-jam closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvioalves sylvioalves sylvioalves left review comments

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@josuah josuah Awaiting requested review from josuah

@tmon-nordic tmon-nordic Awaiting requested review from tmon-nordic

@JarmouniA JarmouniA Awaiting requested review from JarmouniA

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

Assignees

@jfischer-no jfischer-no

Labels

area: Samples Samples area: USB Universal Serial Bus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DWC2 USB Host controller (UHC)

5 participants

@roma-jam @josuah @sylvioalves @jfischer-no @zephyrbot