Skip to content

tests: benchmark: mbedtls: remove legacy crypto Kconfig #102042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaureenHelm merged 1 commit into from
Jan 13, 2026
Merged

tests: benchmark: mbedtls: remove legacy crypto Kconfig #102042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/benchmarks/mbedtls/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
CONFIG_TEST=y

CONFIG_PRINTK=y
CONFIG_MBEDTLS_SHA256=y

CONFIG_MBEDTLS=y
CONFIG_MBEDTLS_PSA_CRYPTO_C=y
Comment on lines 5 to 6
Copy link
Copy Markdown
Contributor

@tomi-font tomi-font Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, how about changing this to CONFIG_PSA_CRYPTO=y?

Copy link
Copy Markdown
Contributor

@tomi-font tomi-font Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I see the folder's called mbedtls so maybe we'd then need to rename it as well...

Copy link
Copy Markdown
Contributor Author

@valeriosetti valeriosetti Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left these Kconfigs intentionally when I reshaped this benchmark. The idea of this test was to benchmark the performance of Mbed TLS so I wanted to keep the same goal. That's why I kept the selection of CONFIG_MBEDTLS and CONFIG_MBEDTLS_PSA_CRYPTO_C instead of the newer CONFIG_PSA_CRYPTO.
Do you think it's worth to make the scope of this test broader?

Copy link
Copy Markdown
Contributor

@tomi-font tomi-font Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense, I think we actually even already discussed this haha, fine as is, could be worth generalizing to any PSA Crypto provider (I don't think it'd be much work?) but not in the scope of this PR.

Expand Down
Loading