Skip to content

LoRaWAN: use consistent naming for backend libraries#102035

Merged
henrikbrixandersen merged 2 commits intozephyrproject-rtos:mainfrom
carlocaione:upstream/lorawan_fix_naming
Jan 14, 2026
Merged

LoRaWAN: use consistent naming for backend libraries#102035
henrikbrixandersen merged 2 commits intozephyrproject-rtos:mainfrom
carlocaione:upstream/lorawan_fix_naming

Conversation

@carlocaione
Copy link
Contributor

@carlocaione carlocaione commented Jan 9, 2026 •
edited
Loading

Rename drivers/lora/loramac_node to drivers/lora/loramac-node to align with the module naming convention (modules/loramac-node).

Also fix the lora-basics-modem vs lora_basics_modem inconsistencies.

@carlocaione carlocaione force-pushed the upstream/lorawan_fix_naming branch from 3a167d7 to 8e80d98 Compare January 9, 2026 15:49
thedjnK
thedjnK reviewed Jan 9, 2026
View reviewed changes
@carlocaione carlocaione force-pushed the upstream/lorawan_fix_naming branch from 8e80d98 to ccfcbb1 Compare January 9, 2026 16:16
@carlocaione carlocaione changed the title drivers: lora: use consistent naming for backend directories drivers: lora: rename loramac_node directory to loramac-node Jan 9, 2026
@zephyrbot zephyrbot added the size: XS A PR changing only a single line of code label Jan 9, 2026
martinjaeger
martinjaeger previously approved these changes Jan 9, 2026
View reviewed changes
thedjnK
thedjnK previously approved these changes Jan 10, 2026
View reviewed changes
@carlocaione carlocaione dismissed stale reviews from thedjnK and martinjaeger via 6771038 January 11, 2026 08:29
@zephyrbot zephyrbot added area: MAINTAINER File and removed size: XS A PR changing only a single line of code labels Jan 11, 2026
@carlocaione carlocaione changed the title drivers: lora: rename loramac_node directory to loramac-node LoRaWAN: use consistent naming for backend libraries Jan 11, 2026
@zephyrbot zephyrbot requested a review from nashif January 11, 2026 13:11
@carlocaione carlocaione marked this pull request as draft January 11, 2026 13:14
@carlocaione
Copy link
Contributor Author

carlocaione commented Jan 11, 2026

Moving this to draft for now because cleaning lora-basics-modem naming is proving more challenging than expected

@carlocaione carlocaione force-pushed the upstream/lorawan_fix_naming branch 2 times, most recently from 4904587 to 9d33733 Compare January 11, 2026 13:40
@github-actions github-actions bot removed manifest manifest-lora_basics_modem manifest-lora-basics-modem DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jan 11, 2026
@zephyrproject-rtos zephyrproject-rtos deleted a comment from github-actions bot Jan 11, 2026
@carlocaione
Copy link
Contributor Author

carlocaione commented Jan 11, 2026

alright @martinjaeger @thedjnK @JordanYates I think this is the best we can do so PTAL.

The problem is that:

  • The naming of the actual external module (lora-basics-modem) is driving the naming of the module/lora-basics-modem directory
  • While we have module/lora-basics-modem we also have drivers/lora/lora_basics_modem/
  • We cannot touch the cmake library naming lora_basics_modem to not break OOT users

So I'm trying to cleanup a bit this mess by:

  • keeping the directories naming consistent by using lora-basics-modem
  • leaving lora_basics_modem only for the library naming

@carlocaione carlocaione marked this pull request as ready for review January 11, 2026 14:25
@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Jan 11, 2026
@carlocaione carlocaione removed the platform: STM32 ST Micro STM32 label Jan 11, 2026
@JordanYates
Copy link
Contributor

JordanYates commented Jan 12, 2026 •
edited
Loading

We cannot touch the cmake library naming lora_basics_modem to not break OOT users

I think it makes more sense to make the naming consistent now, given the library has only existed for a single release, than leave it forever. I don't believe that the name of CMake libraries falls under breaking API changes, since its not an API people write code against.

Either way, LoRa is not currently a stable subsystem.

@carlocaione
drivers: lora: rename lora_basics_modem directory to lora-basics-modem
6d3087d 
Rename the lora_basics_modem backend directory to lora-basics-modem
for consistency with the module naming convention.

Signed-off-by: Carlo Caione <ccaione@baylibre.com>
@carlocaione carlocaione force-pushed the upstream/lorawan_fix_naming branch from 9d33733 to 6d3087d Compare January 12, 2026 09:14
@carlocaione
Copy link
Contributor Author

carlocaione commented Jan 12, 2026

We cannot touch the cmake library naming lora_basics_modem to not break OOT users

I think it makes more sense to make the naming consistent now, given the library has only existed for a single release, than leave it forever. I don't believe that the name of CMake libraries falls under breaking API changes, since its not an API people write code against.

Either way, LoRa is not currently a stable subsystem.

Makes sense, pushed new revision, thanks.

@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Jan 12, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 12, 2026

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@etienne-lms etienne-lms removed the platform: STM32 ST Micro STM32 label Jan 13, 2026
@henrikbrixandersen henrikbrixandersen merged commit 5e35f14 into zephyrproject-rtos:main Jan 14, 2026
29 checks passed
@carlocaione carlocaione deleted the upstream/lorawan_fix_naming branch January 14, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JordanYates JordanYates JordanYates approved these changes

@mniestroj mniestroj mniestroj approved these changes

@awojasinski awojasinski awojasinski approved these changes

@valeriosetti valeriosetti valeriosetti approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@juickar juickar Awaiting requested review from juickar

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@thedjnK thedjnK Awaiting requested review from thedjnK

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@stephanosio stephanosio Awaiting requested review from stephanosio

@nashif nashif Awaiting requested review from nashif

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

Assignees

@JordanYates JordanYates

Labels

area: LoRa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@carlocaione @JordanYates @thedjnK @mniestroj @martinjaeger @awojasinski @valeriosetti @henrikbrixandersen @etienne-lms @zephyrbot