soc: st: stm32: reorganize family-wide common Kconfig #100218
+68
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split STM32 family-wide common Kconfig in two separate files: a new Kconfig file `soc/st/stm32/common/Kconfig` to hold options that affect the common code found in the same directory, and the existing top-level Kconfig file `soc/st/stm32/Kconfig` which now only holds options used by multiple series but not consumed by the common code - for example, options that are used by SoC-specific code or consumed by the STM32Cube HAL module go in this file. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st and
juickar
|
erwango
requested changes
Nov 28, 2025
| # Copyright (c) 2025 STMicroelectronics | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Kconfig options for STM32 family-wide common code |
Member
There was a problem hiding this comment.
Disambiguate 'common'
Suggested change
| # Kconfig options for STM32 family-wide common code | |
| # Kconfig options for STM32 family-wide common/ code |
Comment on lines
+13
to
+14
| # `common/Kconfig` declares all Kconfig options used to | ||
| # configure the family-wide code found in `common/`. |
Member
There was a problem hiding this comment.
A bit unclear. what about:
Kconfig options used to configure the family-wide code
found in `common/` are made available in common/Konfig
Comment on lines
+16
to
+19
| # However, some Kconfig options are shared by all series but | ||
| # not consumed by common code; instead, SoC-specific code, | ||
| # certain drivers or the STM32Cube HAL module will make use | ||
| # of them. Such Kconfig options are declared here. |
Member
There was a problem hiding this comment.
Suggested change
| # However, some Kconfig options are shared by all series but | |
| # not consumed by common code; instead, SoC-specific code, | |
| # certain drivers or the STM32Cube HAL module will make use | |
| # of them. Such Kconfig options are declared here. | |
| # Kconfig options shared by all series, but not consumed by common code, | |
| # such as SoC-specific code, certain drivers or the STM32Cube HAL module | |
| # are declared below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split STM32 family-wide common Kconfig in two separate files: a new Kconfig file
soc/st/stm32/common/Kconfigto hold options that affect the common code found in the same directory, and the existing top-level Kconfig filesoc/st/stm32/Kconfigwhich now only holds options used by multiple series but not consumed by the common code - for example, options that are used by SoC-specific code or consumed by the STM32Cube HAL module go in this file.