treewide: use auto-generated Kconfig compatible macro variables #100216
+3
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace some manually-defined DT_COMPAT_<> Kconfig macro variables with their automatically generated counterparts. In most cases, this is straightforward as the manually defined macro is named identically to the one generated by the build system. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
requested review from
ClaCodes,
butok,
dbaluta,
decsny,
dleach02,
jaz1-nordic,
kl-cruz,
lstnl,
manuargue,
mmahadevan108,
nashif,
nordic-krch,
rlubos,
tmon-nordic and
udaynordic
|
JarmouniA
reviewed
Nov 28, 2025
| # Copyright (c) 2022 Nordic Semiconductor ASA | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| DT_COMPAT_UHC_MAX3421E := maxim,max3421e_spi |
Contributor
There was a problem hiding this comment.
The compatible name should probably be fixed as well, to use - instead of _. Even though I am unable to find a rule in the guidelines regarding compatible naming.
https://docs.zephyrproject.org/latest/contribute/style/devicetree.html
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Contributor
Author
There was a problem hiding this comment.
Outside PR scope.
@MaureenHelm @ozersa @ttmut @yasinustunerg @galak @microbuilder ^^ FYI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some manually-defined
DT_COMPAT_<>Kconfig macro variables with their automatically generated counterparts. In most cases, this is straightforward as the manually defined macro is named identically to the one generated by the build system.See also #100215