Skip to content

tests: Bluetooth: Audio: Reenable some diabled tests that now pass #100210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: Bluetooth: Audio: Reenable some diabled tests that now pass #100210

wants to merge 1 commit into from
+11 −29

Conversation

@Thalley
Copy link
Contributor

@Thalley Thalley commented Nov 28, 2025

Enabled some tests that previously failed, but were not reenable when the fix was applied.

@Thalley
tests: Bluetooth: Audio: Reenable some diabled tests that now pass
50bd4b4 
Enabled some tests that previously failed, but were not reenable
when the fix was applied.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley Thalley force-pushed the renable_cap_ac_test branch from 6438ea6 to 50bd4b4 Compare November 28, 2025 12:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Thalley Thalley marked this pull request as ready for review November 28, 2025 13:45
@Thalley Thalley requested a review from cvinayak November 28, 2025 13:45
@zephyrbot zephyrbot added area: Bluetooth area: Tests Issues related to a particular existing or missing test platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim area: Bluetooth Audio labels Nov 28, 2025
cvinayak
cvinayak approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@cvinayak cvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking aloud, as I did not fix anything related to these tests passing. I suspect they may fail in the future. If I can help then, it may enlighten me of any cases the Controller has not taken care. Till then, so be it. Approved.

@Thalley
Copy link
Contributor Author

Thalley commented Nov 28, 2025

Just thinking aloud, as I did not fix anything related to these tests passing. I suspect they may fail in the future. If I can help then, it may enlighten me of any cases the Controller has not taken care. Till then, so be it. Approved.

Good point to raise. Some of the previous failures may have been related to other changes and bug fixes in the controller, or simply fixed due to timing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cvinayak cvinayak cvinayak approved these changes

@aescolar aescolar Awaiting requested review from aescolar

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@babrsn babrsn Awaiting requested review from babrsn

@fredrikdanebjer fredrikdanebjer Awaiting requested review from fredrikdanebjer

@jhedberg jhedberg Awaiting requested review from jhedberg

@jthm-ot jthm-ot Awaiting requested review from jthm-ot

@larsgk larsgk Awaiting requested review from larsgk

@nashif nashif Awaiting requested review from nashif

@niym-ot niym-ot Awaiting requested review from niym-ot

@sjanc sjanc Awaiting requested review from sjanc

At least 2 approving reviews are required to merge this pull request.

Assignees

@aescolar aescolar

Labels

area: Bluetooth Audio area: Bluetooth area: Tests Issues related to a particular existing or missing test platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim

Projects

Bluetooth LE Audio
Status: In Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thalley @cvinayak @zephyrbot @aescolar