-
Notifications
You must be signed in to change notification settings - Fork 8.3k
llext: adding missing parentheses on macro INSTR_FETCHABLE #100197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
llext: adding missing parentheses on macro INSTR_FETCHABLE #100197
Conversation
|
Hello @andreagilardoni, and thank you very much for your first pull request to the Zephyr project! |
4d5e8e9 to
3cafc31
Compare
3cafc31 to
f382f4f
Compare
f382f4f to
6336ba0
Compare
C macro INSTR_FETCHABLE is missing parentheses in its definition, this could lead to incorrect expansion when combined with logical operators Signed-off-by: Andrea Gilardoni <[email protected]>
6336ba0 to
b425291
Compare
|
pillo79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!



C macro INSTR_FETCHABLE is missing parentheses in its definition, this could lead to incorrect expansion when combined with logical operators. For instance we can have incorrect behaviors at this line:
zephyr/subsys/llext/llext_mem.c
Line 147 in f908d0b