Skip to content

Conversation

@andreagilardoni
Copy link

@andreagilardoni andreagilardoni commented Nov 28, 2025

C macro INSTR_FETCHABLE is missing parentheses in its definition, this could lead to incorrect expansion when combined with logical operators. For instance we can have incorrect behaviors at this line:

!INSTR_FETCHABLE(ext->mem[mem_idx], region_alloc)) {

@github-actions
Copy link

Hello @andreagilardoni, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added area: llext Linkable Loadable Extensions size: XS A PR changing only a single line of code labels Nov 28, 2025
@andreagilardoni andreagilardoni changed the title llext: hotfix: adding missing parentheses on macro INSTR_FETCHABLE llext: : adding missing parentheses on macro INSTR_FETCHABLE Nov 28, 2025
@andreagilardoni andreagilardoni changed the title llext: : adding missing parentheses on macro INSTR_FETCHABLE llext: adding missing parentheses on macro INSTR_FETCHABLE Nov 28, 2025
C macro INSTR_FETCHABLE is missing parentheses in its definition,
this could lead to incorrect expansion when combined with logical
operators

Signed-off-by: Andrea Gilardoni <[email protected]>
@sonarqubecloud
Copy link

@pillo79 pillo79 added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Nov 28, 2025
Copy link
Contributor

@pillo79 pillo79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: llext Linkable Loadable Extensions size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants