CMake: Add a openthread ncp vendor hook #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## zephyr #13 +/- ##
==========================================
+ Coverage 74.02% 76.94% +2.91%
==========================================
Files 368 329 -39
Lines 49793 40599 -9194
==========================================
- Hits 36859 31237 -5622
+ Misses 12934 9362 -3572
|
rlubos
reviewed
May 21, 2020
Collaborator
rlubos
left a comment
rlubos
left a comment
There was a problem hiding this comment.
Thanks for opening the PR towards upstream OpenThread! Since we should not merge this during feature-freeze, we might be able to drop the temporary commit before the merge window is open again.
Contributor
Author
|
The Openthread changes are merged in the upstream. There was a small change after review (OPENTHREAD_NCP_VENDOR_HOOK_SOURCE and OPENTHREAD_NCP_VENDOR_HOOK were combined). This PR requires at least openthread/openthread@7942b00 from upstream. |
Philipp-Wohlgenannt-Tridonic-com
force-pushed
the
openthread-ncp-vendor-hook
branch
from
bd1f45e to
99d8855
Compare
Add NCP vendor hook for vendor sepcific code Signed-off-by: Philipp Wohlgenannt <[email protected]>
Philipp-Wohlgenannt-Tridonic-com
force-pushed
the
openthread-ncp-vendor-hook
branch
from
99d8855 to
35d3bdf
Compare
Philipp-Wohlgenannt-Tridonic-com
changed the title
Contributor
Author
|
@rlubos Is CIFuzz a probelm and do you know how I can solve it? |
Collaborator
|
It seems that somehow the tests are inherited from the upstream OpenThread, let's not bother about it right now. |
rlubos
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a openthread ncp vendor hook.
This pull request already includes a pull request from the openthread/openthread repo (zephyrproject-rtos/zephyr#25450). As soon as that pull request is merged in the openhtread/openthread repo and openthread in this repo is updated, the commit 10650e2 can be dropped.