Rename common.h to mbedtls_common.h #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi-font
approved these changes
Jan 22, 2025
valeriosetti
approved these changes
Jan 22, 2025
Vge0rge
approved these changes
Jan 22, 2025
frkv
force-pushed
the
mbedtls_common
branch
2 times, most recently
from
8cba4fe to
fcf3eac
Compare
-Changing all instances of #include "common.h" to #include "mbedcrypto_common.h" to prevent collitions -Changing the name of common.h to mbedcrypto_common.h -Mbed TLS uses the file name "common.h" for common settings relevant for build. Unfortunately common.h is not guarded with any folder-structure as this is an internal file that is present in the folder where source-files resides. Due to the way that zephyr adds include-folders it will be difficult to prevent someone coming up with the same name and adding the include-folder earlier than Mbed TLS. Note: This change will be proposed upstream in Mbed TLS with the hope that this commit is can be reverted Signed-off-by: Frank Audun Kvamtrø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This change will be proposed upstream in Mbed TLS with the hope that this commit is can be reverted
Description
-Changing all instances of #include "common.h" to
#include "mbedtls_common.h" to prevent collitions
-Changing the name of common.h to mbedtls_common.h -Mbed TLS uses the file name "common.h" for common
settings relevant for build. Unfortunately common.h
is not guarded with any folder-structure as this
is an internal file that is present in the folder
where source-files resides. Due to the way that
zephyr adds include-folders it will be difficult to
prevent someone coming up with the same name and
adding the include-folder earlier than Mbed TLS.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")