-
Notifications
You must be signed in to change notification settings - Fork 6
workflows: Add workflow for syncing module with upstream #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
target_repository: "zephyrproject-rtos/lvgl" | ||
target_branch: "master" | ||
secrets: | ||
PAT_TOKEN: ${{ secrets.ZB_REPO_SYNC_GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephanosio is this a good name for the token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: Do we envision one token with write permissions to all the module repos, or a dedicated token per repo? If dedicated, this should probably be named with the module name included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: Do we envision one token with write permissions to all the module repos, or a dedicated token per repo? If dedicated, this should probably be named with the module name included.
There will be one token for all automated repository sync workflows -- there is not much point in having dedicated token per repo when any workflow in this repository can access all repository secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my POV this is still a good solution overall.
For the exact details of the implementation, I think it is best if @stephanosio (i.e. somebody who actually takes care of the infrastructure) decides on.
@stephanosio any updates? this came up for another repo ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@faxe1008 If you prefer, I could also make the necessary changes myself and merge this PR to expedite the process a bit (there will likely be more changes necessary as I test this).
hal_ethos and maybe cmsis_6 in the future would really benefit from this in the future |
@stephanosio I will incorporate the changes you suggested and then you can take it from there. |
Since some modules owned by the Zephyr organization are not created as a Github fork maintaining them as a complete mirror requires manual pushing. To fix this add a reusable workflow that can be configured for each module to sync a specific branch in our version with upstream. Also adds a sample usage of said workflow for the LVGL module. Signed-off-by: Fabian Blatz <[email protected]>
08dddbf
to
e58adcc
Compare
@stephanosio applied your suggestions, feel free to take over :^) |
Since some modules owned by the Zephyr organization are not created as a Github fork maintaining them as a complete mirror requires manual pushing. To fix this add a reusable workflow that can be configured for each module to sync a specific branch in our version with upstream. Also adds a sample usage of said workflow for the LVGL module.