scripts: genpinctrl: fix multiple F1 issues #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with F1 series pins not present in the GPIO IP files need to be taken into account with the NO_REMAP setting. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add F1 series configurations from pins missing in the GPIO IP configuration files. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
changed the title
erwango
approved these changes
Oct 13, 2020
erwango
requested changes
Oct 13, 2020
Only first remap block was being processed, take into account all of them now. Note that ``FULL_REMAP`` has been adjusted to ``REMAP_FULL`` as it was wrong. Tests updated to cover multiple remap cases. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Some remaps were missing due to an issue with genpinctrl. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Good catch, fixed |
erwango
approved these changes
Oct 13, 2020
galak
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with F1 series pins not present in the GPIO IP files need to be taken into account with the
NO_REMAPsetting. Furthermore, only first remap block was being processed, now all of them are taken into account.Fixes zephyrproject-rtos/zephyr#29120