test: generate the test set dynamically #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
dynamic-testset
branch
5 times, most recently
from
c57e738 to
c62b00d
Compare
fabiobaltieri
requested review from
danieldegrasse,
dkalowsk,
henrikbrixandersen and
kartben
Member
Author
|
Is this a good idea? There's a regular expression in there so I think the answer is no. cc @pdgendt, I'm tempted to do that thing in python but that would probably make it even worse |
Generate the test matrix using the last two stable tags automatically, this way we only have to update the LTS list manually. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
dynamic-testset
branch
from
c62b00d to
4c22980
Compare
Contributor
|
It does look rather complex, also what if a patch release is made, e.g. v4.2.1. You wouldn't test v4.1.0 anymore. |
Member
Author
Ah, right, yeah this needs more thinking. Anyway the basic concept is there let's revisit it down the road, I think what we should have is a file in the main repository we can reference to for the information, similarly to SDK_VERSION. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the test matrix using the last two stable tags automatically, this way we only have to update the LTS list manually.