-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): implementing hono adapter #1739
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduce a new middleware handler for a Hono application, encapsulated in a new file Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
🔇 Files ignored due to path filters (2)
packages/server/package.json
is excluded by!**/*.json
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
,!**/*.yaml
📒 Files selected for processing (3)
- packages/server/src/hono/handler.ts (1 hunks)
- packages/server/src/hono/index.ts (1 hunks)
- packages/server/tests/adapter/hono.test.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/server/src/hono/index.ts
Hey guys! When should we expect the 2.7.0 to be released? |
Hi @LilaRest , I hope around 10/15. The adapter code is actually self contained, so if you are waiting for it, you can copy paste into your code base. When it's released, simply remove the code and import from Also, it'll be great if you could help test the code. I'm not experienced with Hono at all 😄 |
@ymc9 Alright sounds great, thanks! I'll do that way 😄 |
@svetch , I think we need to add an export entry for hono in "package.json" file as well. |
This is what I forgot but I fixed it quickly 😅 |
Awesome. Looks great now! I'll merge after the CI passes. |
Fixes #1270