Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - triple-slash comments are not persisting to schema in logical-prisma-client #1909

Closed
FominSergiy opened this issue Dec 10, 2024 · 2 comments
Milestone

Comments

@FominSergiy
Copy link

Description and expected behavior

The customAttributesAsComments flag released in v2.8.0 works for the output schema of zenstack generate, but does not affect the comments inside the schema generated in .logical-prisma-client/schema.prisma

I updated plugin section accordingly:

plugin prisma {
provider = '@core/prisma'
output = './prisma/schema.prisma'
customAttributesAsComments = true
}

Screenshot 2024-12-10 at 09 17 14

Environment (please complete the following information):

  • ZenStack version: v2.10.0 but the bug found in a feature introduced in v2.8.0
  • Prisma version: 6.0.1

Additional context

Discovered this as I was going through the upgrade of zenstack from v2.5.1 to v2.10.0.

@ymc9
Copy link
Member

ymc9 commented Dec 13, 2024

Fixed in 2.10.1

@ymc9 ymc9 closed this as completed Dec 13, 2024
@FominSergiy
Copy link
Author

great, much much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants