Skip to content

fix: minor fixes addressing AI comments #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymc9 merged 1 commit into from
Dec 30, 2025
Merged

fix: minor fixes addressing AI comments #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/language/src/validators/function-invocation-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export default class FunctionInvocationValidator implements AstValidator<Express
const versionArg = expr.args[0]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== 4 && version !== 7) {
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'first argument must be 4 or 7', {
node: expr.args[0]!,
});
Expand All @@ -212,7 +212,7 @@ export default class FunctionInvocationValidator implements AstValidator<Express
const versionArg = expr.args[0]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== 1 && version !== 2) {
if (version !== undefined && version !== 1 && version !== 2) {
accept('error', 'first argument must be 1 or 2', {
node: expr.args[0]!,
});
Expand Down
2 changes: 2 additions & 0 deletions samples/sveltekit/src/routes/api/model/[...path]/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { schema } from "../../../../zenstack/schema";

const handler = SvelteKitRouteHandler({
apiHandler: new RPCApiHandler({ schema }),
// fully open ZenStackClient is used here for demo purposes only, in a real application,
// you should use one with access policies enabled
getClient: () => db,
});

Expand Down