Skip to content
This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions packages/orm/src/client/executor/name-mapper.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { invariant } from '@zenstackhq/common-helpers';
import {
AliasNode,
BinaryOperationNode,
CaseWhenBuilder,
ColumnNode,
ColumnUpdateNode,
Expand All @@ -10,20 +11,21 @@ import {
FromNode,
IdentifierNode,
InsertQueryNode,
type OperationNode,
OperationNodeTransformer,
PrimitiveValueListNode,
ReferenceNode,
ReturningNode,
SelectAllNode,
SelectionNode,
SelectQueryNode,
type SimpleReferenceExpressionNode,
TableNode,
UpdateQueryNode,
ValueListNode,
ValueNode,
ValuesNode,
type OperationNode,
type SimpleReferenceExpressionNode,
WhereNode,
} from 'kysely';
import type { EnumDef, EnumField, FieldDef, ModelDef, SchemaDef } from '../../schema';
import {
Expand Down Expand Up @@ -183,6 +185,42 @@ export class QueryNameMapper extends OperationNodeTransformer {
return ColumnNode.create(mappedName);
}

protected override transformWhere(node: WhereNode): WhereNode {
if (
BinaryOperationNode.is(node.where) &&
ReferenceNode.is(node.where.leftOperand) &&
ColumnNode.is(node.where.leftOperand.column) &&
node.where.leftOperand.table &&
TableNode.is(node.where.leftOperand.table) &&
// where: { enumColumn: Enum.VALUE }
(ValueNode.is(node.where.rightOperand) ||
// where: { enumColumn: { in: [Enum.VALUE] } }
PrimitiveValueListNode.is(node.where.rightOperand))
) {
const tableName = node.where.leftOperand.table.table.identifier.name;
const columnNode = node.where.leftOperand.column;
const valueNode = node.where.rightOperand;

let resultValue: OperationNode = valueNode;

if (ValueNode.is(valueNode)) {
resultValue = this.processEnumMappingForValue(tableName, columnNode, valueNode) as OperationNode;
} else if (PrimitiveValueListNode.is(valueNode)) {
resultValue = PrimitiveValueListNode.create(
this.processEnumMappingForValues(tableName, valueNode.values.map(() => columnNode), valueNode.values),
);
}

return super.transformWhere(
WhereNode.create(
BinaryOperationNode.create(node.where.leftOperand, node.where.operator, resultValue)
)
);
}

return super.transformWhere(node);
}
Comment thread
DoctorFTB marked this conversation as resolved.
Outdated

protected override transformUpdateQuery(node: UpdateQueryNode) {
if (!node.table) {
return super.transformUpdateQuery(node);
Expand Down
65 changes: 65 additions & 0 deletions tests/e2e/orm/client-api/name-mapping.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ describe('Name mapping tests', () => {
user_role: 'role_user',
});

rawRead = await db.$qbRaw
.selectFrom('users')
.where('user_role', '=', 'role_user')
.selectAll()
.executeTakeFirst();
await expect(rawRead).toMatchObject({
user_email: 'u1@test.com',
user_role: 'role_user',
});

await expect(
db.user.create({
data: {
Expand All @@ -66,6 +76,15 @@ describe('Name mapping tests', () => {
user_role: 'MODERATOR',
});

rawRead = await db.$qbRaw
.selectFrom('users')
.where('user_role', '=', 'MODERATOR')
.selectAll()
.executeTakeFirst();
await expect(rawRead).toMatchObject({
user_role: 'MODERATOR',
});

await expect(
db.$qb
.insertInto('User')
Expand Down Expand Up @@ -146,6 +165,52 @@ describe('Name mapping tests', () => {
posts: [{ title: 'Post1' }],
});

await expect(
db.user.findFirst({
where: { role: 'USER' },
select: {
email: true,
role: true,
},
}),
).resolves.toMatchObject({
email: 'u1@test.com',
role: 'USER',
});

await expect(
db.user.findMany({
where: { role: 'USER' },
select: {
email: true,
role: true,
},
}),
).resolves.toEqual([expect.objectContaining({ email: 'u1@test.com', role: 'USER' })]);

await expect(
db.user.findFirst({
where: { role: { in: ['USER'] } },
select: {
email: true,
role: true,
},
}),
).resolves.toMatchObject({
email: 'u1@test.com',
role: 'USER',
});

await expect(
db.user.findMany({
where: { role: { in: ['USER'] } },
select: {
email: true,
role: true,
},
}),
).resolves.toEqual([expect.objectContaining({ email: 'u1@test.com', role: 'USER' })]);

// select all
await expect(
db.user.findFirst({
Expand Down
Loading