-
-
Notifications
You must be signed in to change notification settings - Fork 17
chore: misc updates #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: misc updates #528
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThis PR updates CLI help text and documentation URLs, standardizes README documentation links and package references, and clarifies policy plugin documentation to state delegation supports only to-one relations and that the field parameter refers to the relation field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @ymc9's task —— View job Pull Request ReviewTodo List:
Changes Summary:
Review Feedback✅ Code Quality & Best Practices
✅ Potential Bugs or Issues
✅ Performance Considerations
✅ Security Concerns
✅ Test Coverage
Recommendation✅ Approve - This is a clean maintenance PR that improves user-facing text and documentation clarity without any functional risks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR contains miscellaneous documentation and text updates:
- Updates the
checkfunction documentation in the policy plugin to more accurately describe its purpose (delegating access control to relations) - Refines the CLI description text to align with other project messaging
- Updates the documentation URL format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/plugins/policy/plugin.zmodel | Improves accuracy of the check function documentation to clarify it delegates access control to relations and only supports to-one relations |
| packages/cli/src/index.ts | Updates the CLI description text from "data layer for modern TypeScript" to "modern data layer for TypeScript" and changes documentation URL from versioned to non-versioned format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Claude finished @ymc9's task —— View job Pull Request ReviewTodo List:
Changes Summary:
Review Feedback✅ Code Quality & Best Practices
✅ Potential Bugs or Issues
✅ Performance Considerations
✅ Security Concerns
✅ Test Coverage
Recommendation✅ Approve - This is a clean maintenance PR that improves user-facing text and documentation clarity without any functional risks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🧠 Learnings (7)
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to **/*.zmodel : ZModel schema files should define database structure and policies that compile to TypeScript via `zenstack generate`
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.{ts,tsx} : Use Kysely as the query builder interface for low-level database queries, avoiding raw SQL when possible
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Database migrations should use Prisma CLI under the hood via ZenStack commands
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.{ts,tsx} : Implement plugin hooks at ORM, Kysely, and entity mutation levels for query interception and customization
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/orm/**/*.test.{ts,tsx} : ORM package tests should include comprehensive client API tests and policy tests
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to **/*.zmodel : Always run `zenstack generate` after modifying ZModel schemas
Applied to files:
README.md
📚 Learning: 2025-11-26T01:55:04.540Z
Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to packages/zenstackhq/cli/**/*.test.{ts,tsx} : CLI package tests should focus on action-specific tests for each command
Applied to files:
README.md
🪛 markdownlint-cli2 (0.18.1)
README.md
28-28: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-test (20.x, sqlite)
- GitHub Check: build-test (20.x, postgresql)
🔇 Additional comments (1)
README.md (1)
52-52: Documentation and package version standardization looks good.The changes standardize package references (removing
@nextin favor of@latestor stable versions) and update documentation URLs to non-versioned paths (/docs/instead of/docs/3.x/), which aligns well with the PR objectives.Also applies to: 66-66, 74-74, 82-83, 90-90
|
Claude finished @ymc9's task —— View job Pull Request ReviewTodo List:
Changes Summary:
Review Feedback✅ Code Quality & Best Practices
✅ Potential Bugs or Issues
✅ Performance Considerations
✅ Security Concerns
✅ Test Coverage
Recommendation✅ Approve - This is a clean maintenance PR that improves user-facing text and documentation clarity without any functional risks. |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.