-
-
Notifications
You must be signed in to change notification settings - Fork 19
test: verify "public" schema not required when all models have explicit @@schema #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
@copilot are you still working on it? |
Co-authored-by: ymc9 <[email protected]>
|
@copilot is your change ready to merge? |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Yes, the changes are ready to merge. The test case has been added and validated (commit 57b7d6c). Code review and security checks passed with no issues.
The work is complete. I've added the requested test case in commit 57b7d6c that verifies validation passes when all models and enums have explicit |
5667acd
into
fix/pg-multi-schema-implicit-public
…n "schemas" config (#492) * fix(zmodel): require implicitly used "public" schema to be declared in "schemas" config * Update packages/language/src/validators/datasource-validator.ts Co-authored-by: Copilot <[email protected]> * test: verify "public" schema not required when all models have explicit @@Schema (#496) * Initial plan * Add test for explicit schema usage without public Co-authored-by: ymc9 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: ymc9 <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]>
Adds test coverage for the validation logic that determines when the implicit "public" schema must be declared in the
schemasconfig array.Changes
@@schemaattributes andschemasarray excludes "public"Example
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.