Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zenstack-v3",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack",
"packageManager": "[email protected]",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion packages/auth-adapters/better-auth/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/better-auth",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack Better Auth Adapter. This adapter is modified from better-auth's Prisma adapter.",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"publisher": "zenstack",
"displayName": "ZenStack CLI",
"description": "FullStack database toolkit with built-in access control and automatic API generation.",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"type": "module",
"author": {
"name": "ZenStack Team"
Expand Down
2 changes: 1 addition & 1 deletion packages/clients/tanstack-query/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/tanstack-query",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "TanStack Query Client for consuming ZenStack v3's CRUD service",
"main": "index.js",
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion packages/common-helpers/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/common-helpers",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack Common Helpers",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/config/eslint-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/eslint-config",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"type": "module",
"private": true,
"license": "MIT"
Expand Down
2 changes: 1 addition & 1 deletion packages/config/typescript-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/typescript-config",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"license": "MIT"
}
2 changes: 1 addition & 1 deletion packages/config/vitest-config/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/vitest-config",
"type": "module",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"license": "MIT",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/create-zenstack/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-zenstack",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "Create a new ZenStack project",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/language/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/language",
"description": "ZenStack ZModel language specification",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"license": "MIT",
"author": "ZenStack Team",
"files": [
Expand Down
8 changes: 7 additions & 1 deletion packages/language/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -561,14 +561,20 @@ export function getAllAttributes(

if (isDataModel(decl) && decl.baseModel) {
if (decl.baseModel.ref) {
attributes.push(...getAllAttributes(decl.baseModel.ref, seen));
const attrs = getAllAttributes(decl.baseModel.ref, seen).filter((attr) => !isNonInheritableAttribute(attr));
attributes.push(...attrs);
}
}

attributes.push(...decl.attributes);
return attributes;
}

function isNonInheritableAttribute(attr: DataModelAttribute) {
const attrName = attr.decl.ref?.name ?? attr.decl.$refText;
return ['@@map', '@@unique', '@@index'].includes(attrName);
}

/**
* Retrieve the document in which the given AST node is contained. A reference to the document is
* usually held by the root node of the AST.
Expand Down
6 changes: 3 additions & 3 deletions packages/language/src/validators/datamodel-validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export default class DataModelValidator implements AstValidator<DataModel> {
return;
}

if (this.isFieldInheritedFromDelegateModel(field)) {
if (this.isFieldInheritedFromDelegateModel(field, contextModel)) {
// relation fields inherited from delegate model don't need opposite relation
return;
}
Expand Down Expand Up @@ -431,8 +431,8 @@ export default class DataModelValidator implements AstValidator<DataModel> {
}

// checks if the given field is inherited directly or indirectly from a delegate model
private isFieldInheritedFromDelegateModel(field: DataField) {
return isDelegateModel(field.$container);
private isFieldInheritedFromDelegateModel(field: DataField, contextModel: DataModel) {
return field.$container !== contextModel && isDelegateModel(field.$container);
}

private validateInherits(model: DataModel, accept: ValidationAcceptor) {
Expand Down
50 changes: 50 additions & 0 deletions packages/language/test/delegate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,54 @@ describe('Delegate Tests', () => {
'can only be applied once',
);
});

it('rejects relation missing the opposite side', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model A {
id Int @id @default(autoincrement())
b B @relation(fields: [bId], references: [id])
bId Int
type String
@@delegate(type)
}

model B {
id Int @id @default(autoincrement())
}
`,
'missing an opposite relation',
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model A {
id Int @id @default(autoincrement())
b B @relation(fields: [bId], references: [id])
bId Int
type String
@@delegate(type)
}

model B {
id Int @id @default(autoincrement())
a A[]
}

model C extends A {
c String
}
`,
);
});
});
2 changes: 1 addition & 1 deletion packages/orm/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/orm",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack ORM",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/policy/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/plugin-policy",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack Policy Plugin",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/schema/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/schema",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack Runtime Schema",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/sdk",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack SDK",
"type": "module",
"scripts": {
Expand Down
13 changes: 1 addition & 12 deletions packages/sdk/src/prisma/prisma-schema-generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,7 @@ export class PrismaSchemaGenerator {
}
}

const allAttributes = getAllAttributes(decl).filter(
(attr) => this.isPrismaAttribute(attr) && !this.isInheritedMapAttribute(attr, decl),
);
const allAttributes = getAllAttributes(decl).filter((attr) => this.isPrismaAttribute(attr));

for (const attr of allAttributes) {
this.generateContainerAttribute(model, attr);
Expand Down Expand Up @@ -241,15 +239,6 @@ export class PrismaSchemaGenerator {
return getStringLiteral(defaultSchemaField?.value) ?? 'public';
}

private isInheritedMapAttribute(attr: DataModelAttribute, contextModel: DataModel) {
if (attr.$container === contextModel) {
return false;
}

const attrName = attr.decl.ref?.name ?? attr.decl.$refText;
return attrName === '@@map';
}

private isPrismaAttribute(attr: DataModelAttribute | DataFieldAttribute) {
if (!attr.decl.ref) {
return false;
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/server",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack automatic CRUD API handlers and server adapters",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/testtools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/testtools",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "ZenStack Test Tools",
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/zod/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/zod",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "",
"type": "module",
"main": "index.js",
Expand Down
2 changes: 1 addition & 1 deletion samples/next.js/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "next.js",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"scripts": {
"generate": "zen generate --lite",
Expand Down
2 changes: 1 addition & 1 deletion samples/orm/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "sample-blog",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"description": "",
"main": "index.js",
"private": true,
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/orm/schemas/delegate/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export class SchemaType implements SchemaDef {
}
},
attributes: [
{ name: "@@index", args: [{ name: "fields", value: ExpressionUtils.array([ExpressionUtils.field("ownerId")]) }] },
{ name: "@@delegate", args: [{ name: "discriminator", value: ExpressionUtils.field("assetType") }] }
],
idFields: ["id"],
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e/orm/schemas/delegate/schema.zmodel
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ model Asset {
comments Comment[]
assetType String

@@index([ownerId])

@@delegate(assetType)
}

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "e2e",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion tests/regression/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "regression",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"type": "module",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions tests/regression/test/v2-migrated/issue-1243.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('Regression for issue 1243', () => {
}
`;

await createTestClient(schema);
await createTestClient(schema, { usePrismaPush: true });
});

it('multiple id fields', async () => {
Expand All @@ -47,6 +47,6 @@ describe('Regression for issue 1243', () => {
}
`;

await createTestClient(schema);
await createTestClient(schema, { usePrismaPush: true });
});
});
2 changes: 1 addition & 1 deletion tests/runtimes/bun/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bun-e2e",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"type": "module",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion tests/runtimes/edge-runtime/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "edge-runtime-e2e",
"version": "3.0.0-beta.29",
"version": "3.0.0-beta.30",
"private": true,
"type": "module",
"scripts": {
Expand Down