Skip to content

Initial code publication #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 23, 2025
Merged

Initial code publication #1

merged 19 commits into from
Jan 23, 2025

Conversation

Horolsky
Copy link
Collaborator

@Horolsky Horolsky commented Jan 11, 2025

Initial code publication

Move the source code from the internal repo, refine the structure, and add a dummy Python package.

The first commit contains the code reviewed and approved for publication by the Volvo Cars Open Source Program Office.
Most of the following changes are structural refinements or dummy configs.

A large part of implementation is in prototype state and is not a subject of review in this pr. The strategy for this debt is the following:

  1. Add system design documentation, structured by objectives and features
  2. Add architectural design, mapping high-level features to framework components with requirements breakdown
  3. Refactor the corresponding components

As one said, everything should be built top-down, except the first time 🙂

@Horolsky Horolsky requested a review from a team January 11, 2025 18:58
@Horolsky Horolsky force-pushed the initial-code-publication branch 3 times, most recently from 20e16b3 to 29cdfe4 Compare January 11, 2025 20:11
@Horolsky Horolsky force-pushed the initial-code-publication branch from 29cdfe4 to f6a52e2 Compare January 11, 2025 20:15
@Horolsky Horolsky added this to the MS1 milestone Jan 12, 2025
@Horolsky Horolsky self-assigned this Jan 12, 2025
@Horolsky Horolsky force-pushed the initial-code-publication branch from 7813cf2 to 8faf320 Compare January 17, 2025 19:40
Generate API reference with local doxygen outside of the Bazel build

TODO: remove after #6
* Refine namespaces and move internals into detail ns
* Remove redundant traits and metafuncs
* Move precise template to decor ns
* Add doxygen docs. Some trivial metafuncs omitted.
* Refactor few templates

Breaking:
* Move json_from and dejsonize from reflect to main ns
@Horolsky Horolsky force-pushed the initial-code-publication branch from dadb352 to 73d458d Compare January 18, 2025 14:44
Move
 * packages/cxx => zmbt-framework/backends/cxx
 * packages/py => zmbt-framework/cli
@Klanor
Copy link

Klanor commented Jan 22, 2025

General note:
Always better to implicitly define constructors/operators of copy/move especially when many templates is used. In case if defould is OK = default can be used to mark.

@Horolsky
Copy link
Collaborator Author

@Klanor Many internal classes are in prototype state and will be refactored before MS3 with the support of static checkers.

@Horolsky
Copy link
Collaborator Author

Oye, @zenseact/beltalowda, @Klanor , I've added the strategy for prototype code refinement to the pr description.

@Horolsky Horolsky closed this Jan 22, 2025
@Horolsky Horolsky reopened this Jan 22, 2025
@Horolsky Horolsky force-pushed the initial-code-publication branch from 3f3ecc6 to 02e9dcc Compare January 22, 2025 12:41
@Horolsky Horolsky force-pushed the initial-code-publication branch from 02e9dcc to a5a897d Compare January 22, 2025 12:47
Add doxygen docs to Environment interfaces and update docs/environment.md.
Interfaces for internal functionality left undocumented - they should be separated from the API in future.
 - Fix code generation issues
 - Fix aliases for bitwise ops
 - add U+00D7 alias for cartesian
@Horolsky Horolsky force-pushed the initial-code-publication branch from 679db45 to c9c5474 Compare January 22, 2025 15:22
@Horolsky Horolsky force-pushed the initial-code-publication branch from bcc3430 to 9c60804 Compare January 22, 2025 18:45
@Horolsky Horolsky merged commit 0b41a19 into main Jan 23, 2025
@Horolsky Horolsky deleted the initial-code-publication branch January 23, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants