-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements and bug fixes #2821
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was mainly looking at this:
"When running a pipeline from the server, the deprecated name property of the StepConfigurationUpdate led to an issue in some cases. That property is now explicitly removed from the update dict."
but LGTM
Describe changes
This PR contains a number of small fixes and improvements:
pagination_utils.depaginate(...)
function now allows passing keyword arguments that will be used when calling the list function. This means we don't have to usefunctools.partial(...)
to apply those arguments to the function before passing it to the depagination.model
property of a pipeline had a wrong error message that was adjusted.name
property of theStepConfigurationUpdate
led to an issue in some cases. That property is now explicitly removed from the update dict.exclude_none
argument of thepydantic_utils.update_model(...)
function was not working when the update was a pydantic model, only if it was a dict. There is not a single place in our code where this function is being called with a dictionary however. I fixed the bug and updated the default value forexclude_none
toFalse
to keep the existing behaviour.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes