fix bugs to parse oci specs #23
Conversation
generate.go
Outdated
There was a problem hiding this comment.
@Mashimiao about the swappiness ,there is a discussion in specs opencontainers/runtime-spec#279 , we can refer to that PR and decide how to fix it
There was a problem hiding this comment.
LGTM, agree with @wangkirin, @Mashimiao can you fixed it? Or any other suggestion will be welcomed.
There was a problem hiding this comment.
@zenlinTechnofreak, @wangkirin I read opencontainers/runtime-spec#279 and related pulls. I think the possible and suitable fix is to set Swappiness with nil, as follows:
Resources: &specs.Resources{ Memory: &specs.Memory{ Swappiness: nil, }, },
Do you agree?
There was a problem hiding this comment.
@Mashimiao Yes, but we'd better to keep '-1' util the PR have merged into specs, thus to keep runnable of the ocitool with master of specs.
There was a problem hiding this comment.
Sorry, I'm a little confused
opencontainers/runtime-spec#233 has been merged and opencontainers/runtime-spec#279 just fixed document. If we did not change '-1', we can't compile octtool with master of specs.
There was a problem hiding this comment.
@Mashimiao Sorry, My meaning is runc have not changed yet, if we change '-1', we could not debug OCT with runc, so my suggestion is waiting util runc have been updated.
reference:
section 'OCI Container JSON Format' in https://github.com/opencontainers/runc/blob/master/README.md
Signed-off-by: Ma Shimiao <[email protected]>
3 participants
Signed-off-by: Ma Shimiao [email protected]