Update logs to contain total points for players WIP #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdabapo
changed the title
jdabapo
changed the title
dumbmatter
reviewed
Mar 26, 2025
Comment on lines
+20
to
+21
| pidTotalPts: number; | ||
| pidAstTotalAst: number | undefined; |
There was a problem hiding this comment.
In theory we don't need to pass the values here because stats are already being sent to the box score UI, so the UI already has all the stats for all players. Not sure how easy it is to access, but that would probably be cleaner than manually passing them in everywhere. lmk if you need help figuring that out.
And related to what I said in the other PR about game sim stuff not being well abstracted... this would be a great feature in the other sports too, but sadly will require some special work for each sport.
|
edit: moved comment to PR #484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a proof of concept for total points for a player after making a shot, Could be expanded to fouls, asts, rbs, and other countable stats. This is somewhat linked to PR #482, because there would be a decent amount of copy and paste needed for this to happen in the
PlayByPlayLogger.tsin terms of changing typesupdated