This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix potential issue with Sitemap test #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gabriel403 reported that some PHP and PHPUnit combinations made the testDisablingValidators() test fail. Based on the reported failure, it appears that different versions of libxml may result in differences in how empty tags are created (e.g., "<lastmod></lastmod>" vs "<lastmod/>"). Using the assertEqualXMLStructure() assertion should correct this.
|
Travis failure was due to inability of travis to spin up a 5.3.3 instance. |
ghost
assigned 
|
Merged to both |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testDisablingValidators() test fail. Based on the reported failure, it appears
that different versions of libxml may result in differences in how empty tags
are created (e.g., "" vs ""). Using the
assertEqualXMLStructure() assertion should correct this.