This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Form Added extra unit tests and some code improvements #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpieters
commented
Sep 14, 2012
kpieters
commented
- Fixed FormCollection::shouldWrap function
- Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181
- Moved check for name to static getName FormMultiCheckbox::render
- Improved readability Zend\Form\Form::setValidationGroup
- Fixed FormCollection::shouldWrap function - Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181 - Moved check for name to static getName FormMultiCheckbox::render - Improved readability Zend\Form\Form::setValidationGroup
|
Please rebase this off of the release branch, and re-submit against that branch. A number of items are already fixed in current release and master branches, and, as such, this introduces conflicts. Thanks! |
|
Sorry -- right after I wrote that last comment, we renamed the branches. Rebase off of master. :) I'm going to attempt this now, to see how difficult it is. |
weierophinney
added a commit
that referenced
this pull request
Sep 18, 2012
|
Merged to master and develop -- thanks! |
ghost
assigned 
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.