This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow PSR-7 messages to Dispatch #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Next` allows any PSR-7 implementations. However, prior to this patch, `Dispatch` required the Stratigilty-specific decorators, which could result in issues if `$next()` was invoked with non-Stratigility instances: ```php return $next($request, new JsonResponse()); ``` This patch adds a test to ensure that `Dispatch` will pass them through properly, and modifies the typehints to use the PSR-7 interfaces. The change is completely BC, as the Stratigility implementations are a superset of PSR-7, and no specfic functionality from them was used previously.
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextallows any PSR-7 implementations. However, prior to this patch,Dispatchrequired the Stratigilty-specific decorators, which could result in issues if$next()was invoked with non-Stratigility instances:This patch adds a test to ensure that
Dispatchwill pass them through properly, and modifies the typehints to use the PSR-7 interfaces. The change is completely BC, as the Stratigility implementations are a superset of PSR-7, and no specfic functionality from them was used previously.Fixes #28.