Provide utility functions for decorating non-standard middleware

[weierophinney]

Per discussion on #134, this patch provides two utility functions for decorating non-standard middleware.

closure() allows decorating callables that follow the PSR-15 middleware interface signature via a CallableMiddlewareDecorator instance:

function Zend\Stratigility\closure(
    callable $middleware
) : Zend\Stratigility\Middleware\CallableMiddlewareDecorator

doublePass() allows decorating callables that follow the double-pass middleware signature (function ($request, $response, callable $next)) via a DoublePassMiddlewareDecorator instance:

function Zend\Stratigility\doublePass(
    callable $middleware,
    Psr\Http\Message\ResponseInterface $response = null
) : Zend\Stratigility\Middleware\DoublePassMiddlewareDecorator

The doublePass() function optionally takes a second argument, a response prototype, for use cases where zend-diactoros is not being used as a PSR-7 implementation.

TODO

• Document these methods (waiting to rebase following a merge of Refactor pipe #134)

[froschdesign]

Closing tag </code> is missing.

[weierophinney]

Fixed and force pushed update.

[vaclavvanik]

new is missing?

[vaclavvanik]

new is missing?

[vaclavvanik]

new is missing?

[weierophinney]

Great eye! Fixed and pushed!

[danizord]

@weierophinney I feel like the name middleware(function ($request, $handler) {}) would look more readable than closure(function($request, $handler) {}). What do you think? Same for doublePassMiddleware().

Also, I'd suggest creating a requestHandler() for closure implementations of RequestHandlerInterface as well. If you agree I can send a PR. :)

[weierophinney]

Also, I'd suggest creating a requestHandler() for closure implementations of RequestHandlerInterface as well. If you agree I can send a PR. :)

I'm not sure we have much of a need for it within Stratigility itself. Where would you see developers using this, exactly?

[weierophinney]

I feel like the name middleware(function ($request, $handler) {}) would look more readable than closure(function($request, $handler) {}). What do you think? Same for doublePassMiddleware().

I suppose; if we do, would you have us change the path() utility function to pathMiddleware() as well? (Asking, so I know whether or not to update #134!)

[weierophinney]

Thanks, @danizord, for the feedback; renamed the functions "middleware" and "doublePassMiddleware".