Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Enhancement: Add Makefile with cs and test targets #500

Merged
merged 3 commits into from
Sep 19, 2015

Conversation

localheinz
Copy link
Member

❗ Blocked by #499.

This PR

  • adds a Makefile with a cs target
  • adds a test target
  • updates CONTRIBUTING.md

πŸ’ Now it's easier than ever to fix coding style issues or run the tests, just run

$ make cs

or

$ make test

@localheinz localheinz self-assigned this Sep 19, 2015
@localheinz localheinz force-pushed the feature/makefile branch 2 times, most recently from 7762331 to b3803a9 Compare September 19, 2015 12:13
@localheinz localheinz changed the title Enhancement: Add Makefile with cs target Enhancement: Add Makefile with cs and test targets Sep 19, 2015
@localheinz localheinz assigned Ocramius and unassigned localheinz Sep 19, 2015
@Ocramius
Copy link
Member

@localheinz should .travis.yml depend on the Makefile now?

@localheinz
Copy link
Member Author

@Ocramius

Actually, I personally don't mind a bit of duplication there - it's easier to see in the build log which step has failed, if you know what I mean.

What do you think?

@Ocramius
Copy link
Member

@localheinz alright.

Ocramius added a commit that referenced this pull request Sep 19, 2015
Enhancement: Add Makefile with cs and test targets
@Ocramius Ocramius merged commit 4a10f4e into zendframework:master Sep 19, 2015
@Ocramius
Copy link
Member

πŸ‘

@localheinz
Copy link
Member Author

Thank you, @Ocramius!

@localheinz localheinz deleted the feature/makefile branch September 19, 2015 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants