feat: move ID utilities to react-uid #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current ID management solution uses a shared variable that is incremented on each call. This works well for basic use-cases, but is dependent on the render order to be consistent. This can cause issues with SSR and code-splitting scenarios.
We have also seen issues with consumers upgrading dependencies and having duplicate IDs from conflicting
container-utilities
versions.Detail
A popular solution seems to be the uuid library, but this isn't viable for SSR and reproducible snapshot testing.
Looking through a react issue I found a reference to https://www.npmjs.com/package/react-uid which seems to match our use-case well.
Some highlights:
@ryanseddon this seems like it could be a good utility for usage in the product specific codebases.
Checklist
yarn start
)