Bump bootsnap from 1.6.0 to 1.18.3 #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Feb 11, 2024
| @@ -13,7 +13,6 @@ | |||
| cache_dir: 'tmp/bootsnap', # Path to your cache | |||
| development_mode: rails_env == "development", | |||
| load_path_cache: true, # optimizes the LOAD_PATH with a cache | |||
| autoload_paths_cache: true, # optimizes ActiveSupport autoloads with cache | |||
There was a problem hiding this comment.
Bootsnap no longer supports the classic Rails class autoloader, which this option refers to.
Samson is not using the classic autoloader. Rather, it's using Zeitwerk. So removing this capability (and configuration) is of no consequence.
grosser
approved these changes
Feb 11, 2024
orien
commented
Feb 11, 2024
| plugin_name = line[/\/plugins\/([^\/]+)/, 1] || raise("not called from a plugin not #{line}") | ||
| plugin_name = line[/^plugins\/([^\/]+)/, 1] || raise("not called from a plugin not #{line}") |
There was a problem hiding this comment.
Adjust the plugin-detecting regex to get the tests passing.
|
@grosser The test suite is passing now. |
grosser
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootsnap
Minor version upgrade 📈🔶 1.6.0 → 1.18.3
[change-log, source-code, gem-diff]
A change of 248 commits. See the full changes on the compare page.