-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3 preparation #4092
Ruby 3 preparation #4092
Changes from all commits
2d1f616
2c2c22e
f961a80
94f73e3
589a829
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -32,7 +32,7 @@ def new | |||||||
case params[:type] | ||||||||
when "users" | ||||||||
options = user_filter | ||||||||
send_data UserCsvPresenter.to_csv(options), type: :csv, filename: "Users_#{options[:datetime]}.csv" | ||||||||
send_data UserCsvPresenter.to_csv(**options), type: :csv, filename: "Users_#{options[:datetime]}.csv" | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The samson/app/presenters/user_csv_presenter.rb Lines 15 to 17 in a370be7
|
||||||||
when "deploy_group_usage" | ||||||||
date_time_now = Time.now.strftime "%Y%m%d_%H%M" | ||||||||
send_data DeployGroupUsageCsvPresenter.to_csv, type: :csv, filename: "DeployGroupUsage_#{date_time_now}.csv" | ||||||||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -73,13 +73,12 @@ def sync!(other) | |||
|
||||
def create_client | ||||
VaultClientWrapper.new( | ||||
DEFAULT_CLIENT_OPTIONS.merge( | ||||
address: address, | ||||
ssl_cert_store: cert_store, | ||||
ssl_verify: tls_verify, | ||||
token: token, | ||||
versioned_kv: versioned_kv? | ||||
) | ||||
**DEFAULT_CLIENT_OPTIONS, | ||||
address: address, | ||||
ssl_cert_store: cert_store, | ||||
ssl_verify: tls_verify, | ||||
token: token, | ||||
versioned_kv: versioned_kv? | ||||
Comment on lines
75
to
+81
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
|
||||
) | ||||
end | ||||
|
||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,5 +24,5 @@ class SamsonPlugin < Rails::Engine | |
|
||
Samson::Hooks.callback :error do |exception, **options| | ||
sentry_options = options.slice(:contexts, :extra, :tags, :user, :level, :fingerprint) | ||
Sentry.capture_exception(exception, sentry_options) | ||
Sentry.capture_exception(exception, **sentry_options) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
message
sent via the the ActionCable::Server::Broadcasting#broadcast method is a Hash.Explicitly send a hash in this method call.