Return error output when git commands fail #3738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2020 10:44
CommandExecutor returns stderr as a seperate stream
|
I like the capturing of err and out! |
|
Yeah I've been writing Golang too long. Guess a Hash achieves the same thing |
patrobinson
force-pushed
the
return-error-output
branch
from
946358c
to
7214f9b
Compare
patrobinson
force-pushed
the
return-error-output
branch
from
7214f9b
to
ba2649d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an issue where git clones failed I found no command output was being logged.
There's two different classes involved in running commands via the
ensure_tag_in_git_repositorycode path where the issue occurs.Therefore I've added logging of command results to both (CommandExecutor and TerminalExecutor)