Rename Component to ComponentView #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| protocol Component { | ||
| protocol ComponentView { |
There was a problem hiding this comment.
Why don't you like just Component? 😃
There was a problem hiding this comment.
I was planning on using that for another thing ;) We can revert it back if it doesn't make sense later on :)
There was a problem hiding this comment.
Just thinking it's not a view, so this name could be confusing.
There was a problem hiding this comment.
I can make another pull request to fix it 😎
vadymmarkov
added a commit
that referenced
this pull request
Oct 4, 2015
Rename Component to ComponentView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.