Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal refactoring #84

Merged
merged 5 commits into from
Feb 6, 2019
Merged

Internal refactoring #84

merged 5 commits into from
Feb 6, 2019

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Feb 6, 2019

  • Removes INJECTION_BUNDLE_NOTIFICATION observer in the application delegate.
  • Refactors the Application model to be a struct instead of a class.
  • Improves the use of Voodoo templates.
  • Restructures the code project to remove additional folders which felt redundant.

@zenangst
Remove INJECTION_BUNDLE_NOTIFICATION observer
96b7cf1
@zenangst
Make Application a struct
ded2156 
This improves performance as the diffing can now properly determine if the item is new or not. When it was a class, it would reload more items than it actually needed.
@zenangst
Add iconStore to Voodoo templates
d8fa3b8 
- Add IconStore to data source to load icon for the items.
- Add custom annotation binding "$RawBinding"
@zenangst
Refactor and restructure project
f0eaa8c 
- Files are moved out of subfolder to make the structure more lean
- Logic controllers now have delegates
@zenangst
Update template
25ecb24
@zenangst zenangst merged commit 2d6b70d into master Feb 6, 2019
@zenangst zenangst deleted the internal/refactoring-part-2 branch February 6, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zenangst