Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Toggle Laser keybind #721

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Add Toggle Laser keybind #721

merged 2 commits into from
Mar 22, 2023

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • title, pairs nicely with the force fire keybind
  • Useful because we don't list laser weapons in the context menu action for switching vehicle weapons and this would be much faster than switching back and forth between laser and missiles (for example)

@mharis001 mharis001 added the feature Adds a new feature label Mar 21, 2023
@mharis001 mharis001 added this to the 1.14.0 milestone Mar 21, 2023
@mharis001 mharis001 requested a review from ampersand38 March 21, 2023 05:22
ampersand38
ampersand38 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@ampersand38 ampersand38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Should we auto-add all laserTargets to Zeus editable?

@mharis001
Copy link
Member Author

No, i don't think you would ever want to edit those directly.

@mharis001 mharis001 merged commit d6f8e15 into master Mar 22, 2023
@mharis001 mharis001 deleted the toggle-laser-keybind branch March 22, 2023 05:21
@ampersand38
Copy link
Member

ampersand38 commented Mar 22, 2023 •
edited
Loading

No, i don't think you would ever want to edit those directly.

Ah, I don't mean edit, but to have visual confirmation of where the laser spot is. I guess hints would be better for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka left review comments

@ampersand38 ampersand38 ampersand38 approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mharis001 @ampersand38 @rautamiekka