Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch argument order in execute code module #474

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Switch argument order in execute code module #474

merged 1 commit into from
Oct 4, 2020

Conversation

neilzar
Copy link
Contributor

@neilzar neilzar commented Sep 30, 2020

When merged this pull request will:

  • Title, to make it the same as custom module argument order.

@neilzar neilzar added the enhancement Improves an existing feature label Sep 30, 2020
@neilzar neilzar added this to the 1.10.0 milestone Sep 30, 2020
CreepPork
CreepPork approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a bit of a breaking change but it's fine. Just let the user know in the next version.

@neilzar neilzar merged commit 6571c0b into master Oct 4, 2020
@mharis001 mharis001 deleted the fix-execute-code-args branch October 4, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neilzar @CreepPork @mharis001