Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash.clonedeep dependency #339

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Remove lodash.clonedeep dependency #339

merged 1 commit into from
Nov 19, 2018

Conversation

juanjoDiaz
Copy link
Collaborator

This should resolve #333

Since lodash modules don't seem to have a reliable release cycle and we don't really need clonedeep. Let's just get rid of it altogether.

This should also have a good impact on performance since now we only do shallow clones where needed instead of lodash.deepclone (which is famously solid and infamously slow).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9978a97 on juanjoDiaz:remove_lodashclonedeep_dependency into 9d8f917 on zemirco:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9978a97 on juanjoDiaz:remove_lodashclonedeep_dependency into 9d8f917 on zemirco:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9978a97 on juanjoDiaz:remove_lodashclonedeep_dependency into 9d8f917 on zemirco:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9978a97 on juanjoDiaz:remove_lodashclonedeep_dependency into 9d8f917 on zemirco:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9978a97 on juanjoDiaz:remove_lodashclonedeep_dependency into 9d8f917 on zemirco:master.

@knownasilya
Copy link
Collaborator

Would be nice to have perf benchmarks.. maybe one day.

@knownasilya
Copy link
Collaborator

Is this a breaking change?

@juanjoDiaz
Copy link
Collaborator Author

Yeah. We could definitely use some performance testing.

And No. It's not a breaking change. Just an internal optimization.

@knownasilya knownasilya merged commit d28955a into zemirco:master Nov 19, 2018
@juanjoDiaz juanjoDiaz deleted the remove_lodashclonedeep_dependency branch September 4, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export data from mongoDb to csv using 'unwide' options fails
3 participants