-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't rename 'unnamed' tabs upon deletion of other tabs #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is already pretty great and
I think including it in tab
does make a lot of sense!
There is still one thing that I would like to see a little bit different:
When opening a tab and not really caring about the name,
I think I know what you want to convey with the (unnamed)
, but I think it
does take up too much space. And should be fine with being omitted.
"(unnamed)" has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
It seems like some underlying map of tabs to numbers still exhibits the old behavior. If I have If other people are observing this I can take a look at it. Hints for where to look would be appreciated. (I'm using 0.13.0 on macOS). |
@ammkrn, I believe we want (am happy about more input): I imagined this here to be in scope of #557: I am not sure if showing the number of the current tab would already |
Thanks for clearing that up; I look forward to seeing how those solutions work out. |
This PR aims to solve issue #474.
I decided to put the logic in
Tab::new
. This approach felt the "cleanest" to me.If this breaks any style guides or should be done differently for other reasons please let me know and I'll change it.