Skip to content

Comments

fix(deps): fix --locked build on rust 1.86#4118

Merged
imsnif merged 1 commit intozellij-org:mainfrom
tranzystorekk:fix-1.86
Apr 8, 2025
Merged

fix(deps): fix --locked build on rust 1.86#4118
imsnif merged 1 commit intozellij-org:mainfrom
tranzystorekk:fix-1.86

Conversation

@tranzystorekk
Copy link
Contributor

Noticed when rebuilding 0.42.1 for rust 1.86.

The cause is bytecodealliance/wasmtime#10184, and the fix is updating the wit-parser dependency to 0.221.3

@imsnif
Copy link
Member

imsnif commented Apr 4, 2025

Thanks for this. I haven't tested this yet, but even if we merge this I wouldn't want to release a version with this yet. We already have far-reaching changes in main and back-porting this change to a patch version will be a bit of work. Can you patch things from your side until the next release?

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Apr 4, 2025

Yeah, patching on the void side is no problem, i made this pr mainly for anyone that tests the --locked build on main branch, and to make the problem/solution known :)

@imsnif imsnif merged commit 3ac98fa into zellij-org:main Apr 8, 2025
6 checks passed
@tranzystorekk tranzystorekk deleted the fix-1.86 branch April 8, 2025 07:33
@imsnif
Copy link
Member

imsnif commented Apr 8, 2025

I just merge this and will test-drive the unreleased changes (mostly because we already had stuff in main) for a week or so before releasing a patch. Thanks again.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 8, 2025
Import upstream patch [1]

[1] zellij-org/zellij#4118

PR:		285840
Approved by:	portmgr (build fix blanket)
dnegreira added a commit to dnegreira/os that referenced this pull request Apr 10, 2025
Bump wasmparser and wit-parser to version 0.221.3
This fixes a FTBFS issue which upstream already fixed.
PR with all the information: zellij-org/zellij#4118
dnegreira added a commit to wolfi-dev/os that referenced this pull request Apr 10, 2025
Bump wasmparser and wit-parser to version 0.221.3
This fixes a FTBFS issue which upstream already fixed.
PR with all the information: zellij-org/zellij#4118

Signed-off-by: David Negreira <david.negreira@chainguard.dev>
netgate-git-updates pushed a commit to pfsense/FreeBSD-ports that referenced this pull request Apr 15, 2025
Import upstream patch [1]

[1] zellij-org/zellij#4118

PR:		285840
Approved by:	portmgr (build fix blanket)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants