fix(plugins): session layouts are still serialized using the legacy plugin syntax (remote:) #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin syntax (remote:)
noirbizarre
force-pushed
the
fix/session-layout-plugins
branch
from
6695e12
to
529ceb9
Compare
noirbizarre
changed the title
noirbizarre
changed the title
|
Good catch!! I changed the domain in the test to use the standard example.com domain because somewhere.com can potentially be a real thing. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2863 and #3157, remote plugins are now designed with their raw URL directly, without the
remote:prefix but they were still serialized using theremote:prefix in session layouts.As a result, session using remote plugins were not able to restore remote plugins (like
zjstatus).This PR just apply the same serialization everywhere to ensure no more
remote:prefix is used.