Toward enable should_render (fix pane render)

src/client/panes/terminal_pane.rs

@@ -81,6 +81,7 @@ impl Pane for TerminalPane {
         for byte in bytes.iter() {
             self.vte_parser.advance(&mut self.grid, *byte);
         }
+        self.set_should_render(true);
     }
     fn cursor_coordinates(&self) -> Option<(usize, usize)> {
         // (x, y)
@@ -160,7 +161,7 @@ impl Pane for TerminalPane {
         //    around
         // 2. When there are wide characters in a pane, since we don't yet handle them properly,
         //    the spill over to the pane to the right
-        // if self.should_render || cfg!(test) {
+        // if self.should_render() {
         if true {
             let mut vte_output = String::new();
             let buffer_lines = &self.read_buffer_as_lines();
@@ -203,7 +204,7 @@ impl Pane for TerminalPane {
                 }
                 character_styles.clear();
             }
-            self.grid.should_render = false;
+            self.set_should_render(false);
             Some(vte_output)
         } else {
             None
@@ -262,15 +263,15 @@ impl Pane for TerminalPane {
     }
     fn scroll_up(&mut self, count: usize) {
         self.grid.move_viewport_up(count);
-        self.grid.should_render = true;
+        self.set_should_render(true);
     }
     fn scroll_down(&mut self, count: usize) {
         self.grid.move_viewport_down(count);
-        self.grid.should_render = true;
+        self.set_should_render(true);
     }
     fn clear_scroll(&mut self) {
         self.grid.reset_viewport();
-        self.grid.should_render = true;
+        self.set_should_render(true);
     }
 }
 
@@ -315,6 +316,7 @@ impl TerminalPane {
         let rows = self.get_rows();
         let columns = self.get_columns();
         self.grid.change_size(rows, columns);
+        self.set_should_render(true);
     }
     pub fn read_buffer_as_lines(&self) -> Vec<Vec<TerminalCharacter>> {
         self.grid.as_character_lines()

src/client/tab.rs

@@ -656,6 +656,11 @@ impl Tab {
     pub fn toggle_fullscreen_is_active(&mut self) {
         self.fullscreen_is_active = !self.fullscreen_is_active;
     }
+    pub fn set_force_render(&mut self) {
+        for pane in self.panes.values_mut() {
+            pane.set_should_render(true);
+        }
+    }
     pub fn render(&mut self) {
         if self.active_terminal.is_none() {
             // we might not have an active terminal if we closed the last pane

src/common/screen.rs

@@ -150,8 +150,9 @@ impl Screen {
         let active_tab_pos = self.get_active_tab().unwrap().position;
         let new_tab_pos = (active_tab_pos + 1) % self.tabs.len();
 
-        for tab in self.tabs.values() {
+        for tab in self.tabs.values_mut() {
             if tab.position == new_tab_pos {
+                tab.set_force_render();
                 self.active_tab_index = Some(tab.index);
                 break;
             }
@@ -168,8 +169,9 @@ impl Screen {
         } else {
             active_tab_pos - 1
         };
-        for tab in self.tabs.values() {
+        for tab in self.tabs.values_mut() {
             if tab.position == new_tab_pos {
+                tab.set_force_render();
                 self.active_tab_index = Some(tab.index);
                 break;
             }
@@ -180,9 +182,10 @@ impl Screen {
 
     pub fn go_to_tab(&mut self, mut tab_index: usize) {
         tab_index -= 1;
-        let active_tab = self.get_active_tab().unwrap();
-        if let Some(t) = self.tabs.values().find(|t| t.position == tab_index) {
-            if t.index != active_tab.index {
+        let active_tab_index = self.get_active_tab().unwrap().index;
+        if let Some(t) = self.tabs.values_mut().find(|t| t.position == tab_index) {
+            if t.index != active_tab_index {
+                t.set_force_render();
                 self.active_tab_index = Some(t.index);
                 self.update_tabs();
                 self.render();
@@ -226,6 +229,7 @@ impl Screen {
         for (_, tab) in self.tabs.iter_mut() {
             tab.resize_whole_tab(new_screen_size);
         }
+        let _ = self.get_active_tab_mut().map(|t| t.set_force_render());
         self.render();
     }